-
Notifications
You must be signed in to change notification settings - Fork 197
USWDS-Site - Changelog: Add entry for Card fix border calc errors [USWDS#5325] #2127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flagging that we should update versionUswds
to 3.5.1 and the base branch to release-3.5.1
Change log version numbers updated 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahoneycm can you resolve conflicts & update the base branch to release-3.5.1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mahoneycm Added some suggestions to reframe the changelog entries to focus on the top user benefit. What I suggested might not actually line up with the top benefit, so take them as optional suggestions. Just trying to make everything understandable at a glance to users who might not be super deep in the system. Curious to hear what you think!
…nto cm-card-border-changelog
@mahoneycm FYI I updated the base branch here, resolved a merge conflict, and updated the version placeholder values as part of the effort to check in on all the 3.5.1 changelog PRs. 🧹 |
Thanks @amyleadem ! Let me know if this needs any further updates! |
@amyleadem Updated summaries and reverted version number to placeholder! 😎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No major concerns, just unclear on the tokens-spacing.yml
entry under summaryAdditional
.
…utput and benefit
@mahoneycm I've added a new suggestion that removes a lot of the mechanics of my earlier suggestion and shortens the entry. Hopefully it makes sense to everyone. I know it is a lot of revisions for a single changelog, but I think it is a worthwhile exercise to see if we can find a common method for writing our summaries. I think we are getting closer! Thanks for your patience on this. |
Co-authored-by: Amy Leadem <[email protected]>
Implemented @amyleadem's recommendation in 75c154c |
Summary
Adds changelog items for spacing token and card component updates from uswds/uswds#5325
Preview link
Spacing token changelog →
Card changelog →