Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

mahoneycm
Copy link
Contributor

@mahoneycm mahoneycm commented Jun 7, 2023

Summary

Adds changelog items for spacing token and card component updates from uswds/uswds#5325

Preview link

Spacing token changelog →
Card changelog →

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flagging that we should update versionUswds to 3.5.1 and the base branch to release-3.5.1

@mahoneycm mahoneycm requested a review from amyleadem July 24, 2023 13:50
@mahoneycm
Copy link
Contributor Author

Change log version numbers updated 👍

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahoneycm can you resolve conflicts & update the base branch to release-3.5.1?

Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mahoneycm Added some suggestions to reframe the changelog entries to focus on the top user benefit. What I suggested might not actually line up with the top benefit, so take them as optional suggestions. Just trying to make everything understandable at a glance to users who might not be super deep in the system. Curious to hear what you think!

@amyleadem amyleadem changed the base branch from main to release-3.5.1 August 2, 2023 18:48
@amyleadem
Copy link
Contributor

@mahoneycm FYI I updated the base branch here, resolved a merge conflict, and updated the version placeholder values as part of the effort to check in on all the 3.5.1 changelog PRs. 🧹

@mahoneycm
Copy link
Contributor Author

Thanks @amyleadem ! Let me know if this needs any further updates!

@mahoneycm mahoneycm requested review from amyleadem and mejiaj August 8, 2023 15:00
@mahoneycm
Copy link
Contributor Author

@amyleadem Updated summaries and reverted version number to placeholder! 😎

@mejiaj mejiaj changed the title USWDS-Site: Changelog items for #5325 USWDS-Site - Changelog: Add entry for Card fix border calc errors [USWDS#5325] Aug 8, 2023
Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major concerns, just unclear on the tokens-spacing.yml entry under summaryAdditional.

@mahoneycm mahoneycm requested a review from mejiaj August 8, 2023 17:06
@amyleadem
Copy link
Contributor

@mahoneycm I've added a new suggestion that removes a lot of the mechanics of my earlier suggestion and shortens the entry. Hopefully it makes sense to everyone.

I know it is a lot of revisions for a single changelog, but I think it is a worthwhile exercise to see if we can find a common method for writing our summaries. I think we are getting closer! Thanks for your patience on this.

@mahoneycm mahoneycm requested a review from amyleadem August 10, 2023 16:38
@mahoneycm
Copy link
Contributor Author

Implemented @amyleadem's recommendation in 75c154c

@amyleadem amyleadem requested a review from thisisdano August 10, 2023 21:53
@mejiaj mejiaj deleted the branch release-3.6.0 August 11, 2023 20:52
@mejiaj mejiaj closed this Aug 11, 2023
@mahoneycm mahoneycm reopened this Aug 11, 2023
@mahoneycm mahoneycm changed the base branch from release-3.5.1 to release-3.6.0 August 11, 2023 21:13
@thisisdano thisisdano merged commit e369039 into release-3.6.0 Aug 18, 2023
@thisisdano thisisdano deleted the cm-card-border-changelog branch August 18, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants