Thanks to visit codestin.com
Credit goes to github.com

Skip to content

USWDS-Site - Changelog: Add entry for Input mask fix hover state [USWDS#5378] #2183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Aug 18, 2023
Merged

USWDS-Site - Changelog: Add entry for Input mask fix hover state [USWDS#5378] #2183

merged 5 commits into from
Aug 18, 2023

Conversation

amyleadem
Copy link
Contributor

@amyleadem amyleadem commented Jul 13, 2023 •
edited
Loading

Summary

Added changelog entries for uswds/uswds#5378

Related PR

Related to uswds/uswds#5378

Fixed a bug that caused the input mask hover state to adopt disabled styling.

Preview link

Input mask changelog

@amyleadem amyleadem mentioned this pull request Jul 13, 2023
Merged
@amyleadem amyleadem marked this pull request as ready for review July 18, 2023 21:45
@amyleadem amyleadem requested review from mahoneycm and mejiaj July 18, 2023 21:46
@amyleadem amyleadem changed the base branch from main to release-3.5.1 July 21, 2023 19:24
mahoneycm
mahoneycm reviewed Aug 7, 2023
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just a comment about potentially removing the empty summaryAdditional items 👍

@mejiaj mejiaj mentioned this pull request Aug 2, 2023
Closed
@mejiaj mejiaj changed the title USWDS-Site: Create changelog for #5378 USWDS-Site - Changelog: Add entry for Input mask fix hover state [USWDS/USWDS#5378] Aug 8, 2023
@mejiaj mejiaj changed the title USWDS-Site - Changelog: Add entry for Input mask fix hover state [USWDS/USWDS#5378] USWDS-Site - Changelog: Add entry for Input mask fix hover state [USWDS#5378] Aug 8, 2023
@amyleadem
Copy link
Contributor Author

@mahoneycm I removed the empty summaryAdditional fields. I think it is a good idea to do so moving forward. Thanks!

@amyleadem amyleadem requested a review from mahoneycm August 8, 2023 18:31
mahoneycm
mahoneycm approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! lgtm!

@amyleadem amyleadem requested a review from thisisdano August 10, 2023 21:53
@mejiaj mejiaj deleted the branch release-3.6.0 August 11, 2023 20:52
@mejiaj mejiaj closed this Aug 11, 2023
@mejiaj mejiaj mentioned this pull request Aug 11, 2023
Merged
@amyleadem amyleadem reopened this Aug 11, 2023
@amyleadem amyleadem changed the base branch from release-3.5.1 to release-3.6.0 August 11, 2023 21:12
@thisisdano thisisdano merged commit 373195f into release-3.6.0 Aug 18, 2023
@thisisdano thisisdano deleted the al-changelog-5378 branch August 18, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@mejiaj mejiaj mejiaj approved these changes

@thisisdano thisisdano thisisdano approved these changes

@mahoneycm mahoneycm mahoneycm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@amyleadem @mejiaj @thisisdano @mahoneycm