USWDS-Site - Changelog: Add entry for Button icon alignment #2207
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
This comment was marked as outdated.
This comment was marked as outdated.
mahoneycm
reviewed
Sep 11, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Co-authored-by: Amy Leadem <[email protected]>
|
@mahoneycm @amyleadem I've done the following:
|
5 tasks
amyleadem
suggested changes
Feb 20, 2024
| items: | ||
| - date: NNNN-NN-NN | ||
| summary: Improved the vertical alignment of `usa-icon` elements inside of buttons. | ||
| summaryAdditional: Spacing can be adjusted using the `$theme-button-icon-gap` setting. |
There was a problem hiding this comment.
Wondering if the addition of this setting should be its own separate entry. Either way, I think it would be helpful if we clarified what "spacing" means. Maybe something like this?
Suggested change
| summaryAdditional: Spacing can be adjusted using the `$theme-button-icon-gap` setting. | |
| summaryAdditional: Also added the `$theme-button-icon-gap` setting, which adjusts the size of the gap between the button's text and icon. |
There was a problem hiding this comment.
I like the idea of separating the visual from the component setting. I've added a new entry for $theme-button-icon-gap [de4cec1].
Co-authored-by: Amy Leadem <[email protected]>
Co-authored-by: Amy Leadem <[email protected]>
Co-authored-by: Amy Leadem <[email protected]>
Co-authored-by: Amy Leadem <[email protected]>
- Update version number - Improve clarity in summaries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changelog entry for uswds/uswds#5359.
Related PR
Related to uswds/uswds#5398.
Preview link
Screenshots
Settings page
Component page