Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update Complex Form: Progress Easily with Disabled States guidance #2744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 15, 2024
Merged

Update Complex Form: Progress Easily with Disabled States guidance #2744

merged 9 commits into from
Oct 15, 2024

Conversation

finekatie
Copy link
Contributor

@finekatie finekatie commented Jul 5, 2024 •
edited
Loading

Summary

Update What to do and What not to do sections with new Disabled States guidance.

Important

We need to update the changelog date before merge.

Related issue

Affects #2246

Does not close it as there are two other PRs that will need to be created for other pages.

Related to #2776

Preview link:

Preview link:
Progress easily preview

Problem statement

Current page does not have guidance for disabled states.
Research and discussion among USWDS team members have resulted in a solution

Solution

Will be adding What to do and What not to do guidance to this page as part of a Phase 1 of Disabled States work.

Testing and review

  • Make sure copy is in the correct place
  • Make sure copy has no errors or typos
  • Make sure links work

!ALERT!

I believe we'll need to add changelog - this page does not appear to have one.

@finekatie
Update progress-easily.md
0c6e902 
Update What to do and What not to do sections with new Disabled States guidance.

Preparing this branch for the update.
@finekatie finekatie added Affects: Content Relates to content Affects: Usability Relates to the usability of our code or components labels Jul 5, 2024
@finekatie finekatie self-assigned this Jul 5, 2024
@finekatie
Copy link
Contributor Author

Preparing this PR today. Awaiting guidance on where the content lives in the list. Will edit the branch and request review once it's ready.

@finekatie finekatie mentioned this pull request Jul 5, 2024
Closed
5 tasks
@finekatie
Added do/do not statements for disabled states
a3f857b 
Added a "do" statement and "do not" statement at end of each list pertaining to disabled states.
@finekatie
removed placeholder text
b20be4f 
removed placeholder text from top of "do" list.
This was referenced Aug 11, 2024
Closed
Merged
jaclinec
jaclinec approved these changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@jaclinec jaclinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good to me!

@amyleadem
Copy link
Contributor

@finekatie

I added a changelog for this update. I also noticed that the changelogs for the "Progress easily" (Before | After) and "Establish Trust" (Before | After) pages were not hooked up properly, so I took the liberty of fixing those up in 86e7b47.

Can you confirm that everything looks good with the changelogs on these pages?

amyleadem
amyleadem approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@finekatie
Copy link
Contributor Author

@finekatie

I added a changelog for this update. I also noticed that the changelogs for the "Progress easily" (Before | After) and "Establish Trust" (Before | After) pages were not hooked up properly, so I took the liberty of fixing those up in 86e7b47.

Can you confirm that everything looks good with the changelogs on these pages?

CONFIRMED!!!!

@finekatie finekatie removed the request for review from alex-hull August 23, 2024 15:36
@finekatie
Copy link
Contributor Author

This is ready for FFR. @thisisdano , when you have a chance, please review.

@finekatie finekatie requested a review from thisisdano August 23, 2024 15:37
thisisdano
thisisdano reviewed Sep 9, 2024
View reviewed changes
@finekatie
Copy link
Contributor Author

Hi @thisisdano , is there anything else I need to do to merge this?

thisisdano
thisisdano reviewed Oct 4, 2024
View reviewed changes
thisisdano
thisisdano reviewed Oct 15, 2024
View reviewed changes
@thisisdano
Copy link
Contributor

Merging over a htmlproofer fail that I don't want to block this work any longer

@thisisdano thisisdano merged commit 363b897 into main Oct 15, 2024
9 of 11 checks passed
@thisisdano thisisdano deleted the kf-disabledstates-progresseasily branch October 15, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@thisisdano thisisdano thisisdano left review comments

@amyleadem amyleadem amyleadem approved these changes

@jaclinec jaclinec jaclinec approved these changes

@amycole501 amycole501 amycole501 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@finekatie finekatie

Labels

Affects: Content Relates to content Affects: Usability Relates to the usability of our code or components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@finekatie @amyleadem @thisisdano @jaclinec @amycole501