Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Form component: Updated Disabled States guidance #2776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 4, 2024
Merged

Form component: Updated Disabled States guidance #2776

merged 15 commits into from
Oct 4, 2024

Conversation

finekatie
Copy link
Contributor

@finekatie finekatie commented Aug 11, 2024 •
edited
Loading

Summary

Add Disabled states guidance section with new guidance.

Related issue

Affects #2246

Does not close it as there are two other PRs for other pages.

Related to #2744

Preview link:

Preview link: Form component

Form template page

Problem statement

Current page does not have guidance for disabled states.
Research and discussion among USWDS team members have resulted in a solution

Solution

Will be adding accessibility guidance to this page as part of a Phase 1 of Disabled States work.

Testing and review

  • Make sure copy is in the correct place
  • Make sure copy has no errors or typos
  • Make sure links work

!ALERT!

  • We'll need to update the changelog

@finekatie
Form component: Updated Disabled States guidance
f6a353d 
Adding a section to guidance for disabled states.
This was referenced Aug 11, 2024
Closed
Closed
@finekatie finekatie self-assigned this Aug 11, 2024
@finekatie finekatie added Affects: Accessibility 🟡 Relates to the accessibility of our components Affects: Content Relates to content Affects: Guidance Relates to guidance Affects: Usability Relates to the usability of our code or components labels Aug 11, 2024
@finekatie finekatie mentioned this pull request Aug 11, 2024
Merged
@finekatie finekatie requested a review from amyleadem August 11, 2024 22:32
jaclinec
jaclinec suggested changes Aug 12, 2024
View reviewed changes
Copy link
Contributor

@jaclinec jaclinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great except one tiny thing. For the sentence "If you must use disabled states, follow best practices." The "must" should be italicized. Once that is changed it is good to go!

@finekatie
Copy link
Contributor Author

Everything looks great except one tiny thing. For the sentence "If you must use disabled states, follow best practices." The "must" should be italicized. Once that is changed it is good to go!

All set!

@finekatie finekatie requested a review from jaclinec August 12, 2024 21:08
@finekatie
Adding changelog to page.
e4e53df 
Form component page needs changelog update with this section addition. Just added it.
@finekatie
Copy link
Contributor Author

Added changelog but realized this is also in use on the Form templates page and this update isn't the same as what will be seen on form templates page. Will need help resolving.

@finekatie
Copy link
Contributor Author

Closed #2775 in favor of this. Copy changes to clarify are coming and will submit for FFR when complete.

mahoneycm
mahoneycm reviewed Aug 22, 2024
View reviewed changes
jaclinec
jaclinec approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@jaclinec jaclinec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@finekatie finekatie requested review from mahoneycm and thisisdano and removed request for amycole501 and amyleadem August 23, 2024 21:50
@finekatie
Copy link
Contributor Author

Hey @mahoneycm , I merged your changes and it's ready for Dan to review. Take a look if you want to confirm :)
Thank you so much for all the help!

mahoneycm
mahoneycm approved these changes Aug 26, 2024
View reviewed changes
Copy link
Contributor

@mahoneycm mahoneycm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@finekatie lgtm! I also added a preview link to the form template page since this page is updated with the same content 👍

thisisdano
thisisdano suggested changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@thisisdano thisisdano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like the changelog to be a bit more specific

@thisisdano thisisdano requested a review from amyleadem September 9, 2024 04:33
@thisisdano
Copy link
Contributor

I also added @amyleadem as a reviewer for another editorial eye.

amyleadem and others added 2 commits September 12, 2024 14:57
Merge branch 'main' of https://github.com/uswds/uswds-site into kf-di…
4b3c3b7 
…sabledstates-formcomponent
@amyleadem @thisisdano
Tweak copy
98f7a24 
Co-authored-by: Dan O. Williams <[email protected]>
amyleadem
amyleadem suggested changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Added a couple of small suggestions below. Let me know if you have any questions.

amyleadem
amyleadem approved these changes Sep 16, 2024
View reviewed changes
Copy link
Contributor

@amyleadem amyleadem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Important

We need to update the changelog date before merge.

@annepetersen
Update component-form.yml
34b1eb7 
added changelog date
@annepetersen
Copy link
Contributor

Was hoping to update the changelog and merge, but this has some tests failing, so that date addition might be premature. Intending to look again on Monday.

@annepetersen annepetersen self-assigned this Sep 27, 2024
@annepetersen annepetersen self-requested a review September 27, 2024 21:00
@annepetersen
Copy link
Contributor

@amyleadem, could you look at the failing tests here?

annepetersen
annepetersen approved these changes Oct 4, 2024
View reviewed changes
Copy link
Contributor

@annepetersen annepetersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@annepetersen annepetersen merged commit e0a8d87 into main Oct 4, 2024
11 checks passed
@annepetersen annepetersen deleted the kf-disabledstates-formcomponent branch October 4, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annepetersen annepetersen annepetersen approved these changes

+6 more reviewers

@amycole501 amycole501 amycole501 approved these changes

@thisisdano thisisdano thisisdano requested changes

@mahoneycm mahoneycm mahoneycm approved these changes

@amyleadem amyleadem amyleadem approved these changes

@jaclinec jaclinec jaclinec approved these changes

@alex-hull alex-hull alex-hull approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@annepetersen annepetersen

@finekatie finekatie

Labels

Affects: Accessibility 🟡 Relates to the accessibility of our components Affects: Content Relates to content Affects: Guidance Relates to guidance Affects: Usability Relates to the usability of our code or components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@finekatie @thisisdano @annepetersen @mahoneycm @amyleadem @jaclinec @amycole501 @alex-hull