USWDS-Site: Add changelog for date range picker aria-disabled updates [#6013] #2817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahoneycm
suggested changes
Sep 16, 2024
mahoneycm
reviewed
Sep 18, 2024
| items: | ||
| - date: NNNN-NN-NN | ||
| summary: Added `aria-disabled` to the list of expected attributes. | ||
| summaryAdditional: Now, the component will disable toggle when the `aria-disabled` attribute is present. |
There was a problem hiding this comment.
Question: Should we mention that the input is disabled as well?
Suggested change
| summaryAdditional: Now, the component will disable toggle when the `aria-disabled` attribute is present. | |
| summaryAdditional: Now, the component will disable the text input and calendar toggle when the `aria-disabled` attribute is present. |
|
Oh it looks like we have two PRs for the same work. This and #2794. We generally only need one changelog PR for each USWDS PR. Even though this is a second changelog/component, we can bundle both changes in one PR. #2794 seems to have more discussion so I opt we close this PR in favor of that one, and bring the date range picker changes there! |
|
Closing this PR in favor of #2794. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR provides a changelog entry for the updates made to the date range picker component. The
readonlyattribute has been added toaria-disabledto mimic the disabled behaviors while remaining discoverable for accessibility purposes.Related issue
USWDS - Date Picker: Updated toggleCalendar function to account for aria-disabled attribute + readonly #6013
Preview link
USWDS-Site: Date Range Picker
Testing and review