Revise all e2e tests to use the kind cluster with local registry #1137
Conversation
2cc651b to
18ce5f7
Compare
|
✅ Doc deploy preview ready: https://deploy-preview-pr-1137--v6d.netlify.app |
|
The dask CI looks work! Could you please revise all k8s test cases to use the local registry? Thanks! |
|
No problem. I have added the feature |
1eb10df to
7587ff5
Compare
Signed-off-by: Ye Cao <[email protected]>
979b543 to
fd76a65
Compare
There was a problem hiding this comment.
Why ghcr instead of local registry?
There was a problem hiding this comment.
The local registry is only for testing, for others using vineyard operator in their environment, the image should be able to be downloaded normally.
cfaf6d9 to
6de711c
Compare
Signed-off-by: Ye Cao <[email protected]>
6de711c to
12a1cdf
Compare
|
The bugs in the failover demo are fixed here. |
| run: | | ||
| touch /tmp/e2e-k8s.config | ||
| export KUBECONFIG=/tmp/e2e-k8s.config | ||
| bash k8s/test/hack/build-kind-cluster-with-local-registry.sh |
There was a problem hiding this comment.
I suggest moving the "install cert-manager" and "deploying vineyardd cluster" steps to here as well to further reduce the duplications in "xxxx/e2e.yaml"s.
| kubectl apply -f - | ||
| #sleep 120 | ||
| #kubectl describe pod $(kubectl get po -l app=dask-repartition-job2 -n vineyard-job -oname | awk -F '/' '{print $2}') -n vineyard-job | ||
| #kubectl logs -f $(kubectl get po -l app=dask-repartition-job2 -n vineyard-job -oname | awk -F '/' '{print $2}') -n vineyard-job |
There was a problem hiding this comment.
Remove the temporary debug lines.
Signed-off-by: Ye Cao <[email protected]>
1dc745d to
eb5002a
Compare
| kind load docker-image vineyardcloudnative/vineyard-operator:latest | ||
| docker tag vineyardcloudnative/vineyard-operator:latest localhost:5001/vineyard-operator:latest | ||
| docker push localhost:5001/vineyard-operator:latest | ||
| export IMG=localhost:5001/vineyard-operator:latest |
There was a problem hiding this comment.
Why not make install-vineyard-operator as you have already added the target in Makefile?
d0aeb91 to
f3d6d1d
Compare
Signed-off-by: Ye Cao <[email protected]>
f3d6d1d to
5ed19da
Compare
|
Done, please take another look at this. @sighingnow |
What do these changes do?
The pr is to use the
local registryof kind forrepartition dask e2e test.If the repartition e2e test passed, we can consider replacing all e2e tests here as it can resolve problems like
No space left on device error on CI. Also, the pr needs to wait for the e2e tool to support for testing on a existing kubernetes cluster.