mirrored from https://chromium.googlesource.com/v8/v8.git
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Stage 3 Proposal: Object.getOwnPropertyDescriptors #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There a [stage 3 proposal](https://github.com/tc39/proposal-object-getownpropertydescriptors#objectgetownpropertydescriptors-proposal-polyfill) waiting to be implemented in at least two browsers [in order to make it to stage 4](tc39/proposal-object-getownpropertydescriptors#9). Tests has been submitted to test262 by the champion ( @ljharb ) so the last bit would be to actually implement it in core. These changes have been successfully tested already after a clean `make native` and double-verified manually within d8 console itself. Thanks in advance for considering this PR or for clarifying what else is needed in order to integrate such proposal. Best Regards
|
apparently there is a native patch in here, putting down for record sake. |
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Feb 8, 2016
…8#9 id:180001 of https://codereview.chromium.org/1609233002/ ) Reason for revert: [Sheriff] Breaks gcmole: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20gcmole/builds/6260 Original issue's description: > Do not eagerly instantiate accessors' JSFunction. > > BUG= > > Committed: https://crrev.com/4d46b510caf534d770ce19a01a11b8796304471b > Cr-Commit-Position: refs/heads/master@{#33812} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1679683004 Cr-Commit-Position: refs/heads/master@{#33814}
|
Please keep in mind that this is only a GitHub mirror of V8's 'real' repository. In order to submit changes please follow the instructions at https://github.com/v8/v8/wiki/Contributing. |
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Feb 23, 2016
…8#9 id:160001 of https://codereview.chromium.org/1712003003/ ) Reason for revert: [Sheriff] Seems to break gcmole: https://build.chromium.org/p/client.v8/builders/V8%20Linux/builds/8295 Original issue's description: > Add WasmFrame, backtraces reflect wasm's presence > > For now WasmFrame doesn't summarize the wasm frames. That'll require adding the > metadata in wasm-compiler similar to DeoptimizationInputData. > > Teach the basic backtrace to iterate over stack frames instead of JS frames. > > Update the wasm stack test. > > `git cl format` touches random lines in files I touch. > > [email protected] > TEST=d8 --test --expose-wasm test/mjsunit/mjsunit.js test/mjsunit/wasm/stack.js > > Committed: https://crrev.com/aeca945786dcccad3efecfddbf2c07aefa524a56 > Cr-Commit-Position: refs/heads/master@{#34220} [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1730673002 Cr-Commit-Position: refs/heads/master@{#34221}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Mar 24, 2016
…t return. (patchset v8#9 id:160001 of https://codereview.chromium.org/1818873003/ ) Reason for revert: [Sheriff] Seems to break nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/6019 Original issue's description: > [Interpreter] Adds support to fetch return value on break at return. > > Debugger fetches the return value of a function when we break at return. > Interpreter holds the return value in accumulator. This is not stored in a > specified location on stack and hence it is not possible to look it up from > stack similar to full-codegen or optimized frames. This cl adds support to > store the value of accumulator on debug breaks. The value of accumulator is > passed to the runtime function and is then stored in thread local data. > > Also changes full-codegen implementation to match that of ignition. > The return value from full-codegen is also stored in thread local data. > The return value is fetched directly thread local data instead of > finding it by iterating over frames. > > BUG=v8:4280, v8:4690 > LOG=N > > Committed: https://crrev.com/fb65527b75754bcf3b173f16f5d0b04a1c6d9b99 > Cr-Commit-Position: refs/heads/master@{#35060} [email protected],[email protected],[email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4280, v8:4690 Review URL: https://codereview.chromium.org/1834733002 Cr-Commit-Position: refs/heads/master@{#35065}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 15, 2016
… id:180001 of https://codereview.chromium.org/1838283003/ ) Reason for revert: The boilerplate is copied based on the boilerplate + memento size, which reads off the end of the boilerplate. Original issue's description: > Migrate FastCloneShallowObjectStub to TurboFan > > BUG= > > Committed: https://crrev.com/4c2b04542f263b2679194f9fb75672ebbe72b924 > Cr-Commit-Position: refs/heads/master@{#35330} > > Committed: https://crrev.com/7fdfdc12d4e4291348112ace4278a827f57f2eb9 > Cr-Commit-Position: refs/heads/master@{#35494} [email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1888043006 Cr-Commit-Position: refs/heads/master@{#35544}
southerngs
pushed a commit
to southerngs/v8-git-mirror
that referenced
this pull request
May 3, 2016
Merged 03975be [turbofan] Remove some clever-but-wrong bits from select lowering. BUG=chromium:600593 LOG=N [email protected] Review URL: https://codereview.chromium.org/1877223005 . Cr-Commit-Position: refs/branch-heads/5.1@{v8#9} Cr-Branched-From: 167dc63-refs/heads/5.1.281@{#1} Cr-Branched-From: 03953f5-refs/heads/master@{#35282}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jun 24, 2016
…id:160001 of https://codereview.chromium.org/2090333002/ ) Reason for revert: [Sheriff] Breaks layout tests: https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/7700 Please rebase upstream first if intended. Original issue's description: > Use JS_ERROR_TYPE to check for error objects. > > Replace explicit Object::IsErrorObject() with macro generated functions Object::IsJSError() and HeapObject::IsJSError(). > > BUG= > > Committed: https://crrev.com/90e4fd136387ca7271d8ea87f4fc667e4f55063b > Cr-Commit-Position: refs/heads/master@{#37244} [email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2092083002 Cr-Commit-Position: refs/heads/master@{#37250}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jul 14, 2016
…e access to (patchset v8#9 id:160001 of https://codereview.chromium.org/2034083002/ ) Reason for revert: Causes crashes on Canary Original issue's description: > Don't compile functions in a context the caller doesn't have access to > > Instead just return undefined > > A side effect of this is that it's no longer possible to compile > functions in a detached context. > > BUG=chromium:541703 > [email protected],[email protected] > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng > > Committed: https://crrev.com/992e34c21635b179a993b82ac1d81753e7a6a57a > Cr-Commit-Position: refs/heads/master@{#37657} [email protected],[email protected],[email protected] # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:541703, chromium:628053 Review-Url: https://codereview.chromium.org/2148163002 Cr-Commit-Position: refs/heads/master@{#37736}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Aug 18, 2016
…8#9 id:180001 of https://codereview.chromium.org/2240463002/ ) Reason for revert: Revert again... Original issue's description: > [Interpreter] Introduce InterpreterCompilationJob > > Adds InterpreterCompilationJob as a sub-class of > CompilationJob, to enable off-thread bytecode > generation. Currently only used in > Interpreter::MakeBytecode. > > As part of this change, CompilationJob is modified > to make it less specific to optimized compilation, > renaming the phases as follows: > - CreateGraph -> PrepareJob > - OptimizeGraph -> ExecuteJob > - GenerateCode -> FinalizeJob > > RegisterWeakObjectsInOptimizedCode is also moved out > of CompilationJob and instead becomes a static function > on Compiler. > > BUG=v8:5203 > > Committed: https://crrev.com/1fb6a7e697e8bc5b4af51647553741f966e00cdc > Committed: https://crrev.com/785990e9fc0dd9a9d963d25d0bed2909165e4ca9 > Committed: https://crrev.com/d7c6195c4c5cdc080caa74dfe2ae9ecab69bea73 > Cr-Original-Original-Commit-Position: refs/heads/master@{#38662} > Cr-Original-Commit-Position: refs/heads/master@{#38668} > Cr-Commit-Position: refs/heads/master@{#38725} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Review-Url: https://codereview.chromium.org/2260583002 Cr-Commit-Position: refs/heads/master@{#38727}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 1, 2016
…id:160001 of https://codereview.chromium.org/2272383002/ ) Reason for revert: Breaks cctest/test-api-interceptors/QueryInterceptor on the waterfall Original issue's description: > [api] Add interceptor for defineProperty(). > > With the Indexed/GenericNamedPropertyDefinerCallback it is possible to intercept Object.defineProperty() calls. > > Requests that call JSReceiver::OrdinaryDefineOwnProperty() internally, also trigger the interceptor. This includes Object.freeze(), Object.preventExtensions(), and Object.seal(). > > BUG= > > Committed: https://crrev.com/b9d985975cf3bab0ded0cec9fafd3799f9bde29a > Cr-Commit-Position: refs/heads/master@{#39094} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2303533004 Cr-Commit-Position: refs/heads/master@{#39095}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 23, 2016
…001 of https://codereview.chromium.org/2335343007/ ) Reason for revert: Blocks Roll https://codereview.chromium.org/2366733002/ Original issue's description: > Pool implementation for zone segments > > BUG=v8:5409 > > Committed: https://crrev.com/37c688a24578e787d3d8941093563ed049c3497e > Cr-Commit-Position: refs/heads/master@{#39631} [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5409 Review-Url: https://codereview.chromium.org/2365843002 Cr-Commit-Position: refs/heads/master@{#39652}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 28, 2016
…(patchset v8#9 id:160001 of https://codereview.chromium.org/2364923002/ ) Reason for revert: OOMs in nosnap debug: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20nosnap%20-%20debug/builds/9572 Original issue's description: > [heap] New heuristics for starting of incremental marking. > > The motivation for this patch is to move more marking work to tasks. > This is done by postponing the start of incremental marking until > a marking task is running. > > This patch introduces a soft and a hard limits for incremental marking. > When the soft limit is reached, the marking task is scheduled. > If the hard limit is reached before the task is running, then > incremental marking is started without waiting for the task. > > BUG=chromium:616434 > LOG=NO > > Committed: https://crrev.com/55683ddd2a32e0dfb8df66271fbf53e3618cce9d > Cr-Commit-Position: refs/heads/master@{#39831} [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:616434 Review-Url: https://codereview.chromium.org/2375983002 Cr-Commit-Position: refs/heads/master@{#39833}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Sep 28, 2016
…atchset v8#9 id:160001 of https://codereview.chromium.org/2364923002/ )" This reverts commit a5440d1. BUG=chromium:616434 [email protected] LOG=NO Review-Url: https://codereview.chromium.org/2379663002 Cr-Commit-Position: refs/heads/master@{#39838}
targos
referenced
this pull request
in nodejs/v8
Sep 30, 2016
targos
referenced
this pull request
in nodejs/v8
Nov 5, 2016
cameni
pushed a commit
to Outerra/v8
that referenced
this pull request
Nov 30, 2016
Revision: 08377af BUG=v8:5640 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Review URL: https://codereview.chromium.org/2513403002 . Cr-Commit-Position: refs/branch-heads/5.6@{v8#9} Cr-Branched-From: bdd3886-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f659-refs/heads/master@{#41014}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Jan 26, 2017
…patchset v8#9 id:160001 of https://codereview.chromium.org/2630233003/ ) Reason for revert: Some heap tests are broken leading to failures on nosnap builds: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug/builds/3677 Reverting again until tests are fixed to keep bots green. Original issue's description: > [regexp] Store named captures on the regexp result > > This implements storing named captures on the regexp result object. > For instance, /(?<a>.)/u.exec("b") will return a result such that: > > result.group.a // "b" > > https://tc39.github.io/proposal-regexp-named-groups/ > > BUG=v8:5437 > > Review-Url: https://codereview.chromium.org/2630233003 > Cr-Original-Original-Commit-Position: refs/heads/master@{#42532} > Committed: https://chromium.googlesource.com/v8/v8/+/70000946eb2a9155679528702a766219a1fcf154 > Review-Url: https://codereview.chromium.org/2630233003 > Cr-Original-Commit-Position: refs/heads/master@{#42570} > Committed: https://chromium.googlesource.com/v8/v8/+/ee94fa11ed63477393c6534c352ebac6e502396c > Review-Url: https://codereview.chromium.org/2630233003 > Cr-Commit-Position: refs/heads/master@{#42676} > Committed: https://chromium.googlesource.com/v8/v8/+/8bf52534f6bf86821a1589dcbcb7335052c1f94f [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5437 Review-Url: https://codereview.chromium.org/2654233002 Cr-Commit-Position: refs/heads/master@{#42681}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Feb 10, 2017
…analysis to be deferred. (patchset v8#9 id:180001 of https://codereview.chromium.org/2650883002/ ) Reason for revert: Issue on arm64: https://build.chromium.org/p/client.v8.ports/builders/V8%20Linux%20-%20arm64%20-%20sim/builds/5752 Original issue's description: > [Compiler] Enable handles created during parsing and scope analysis to be deferred. > > In order to compile eager inner functions on a background thread we need to > keep the handles created during parsing and scope analysis alive until the > background compilation is complete. In order to do that, we allocate the > handles in a deferred handle scope and keep the deferred handles alive with > a shared_ptr in the ParseInfo and CompileInfo respectively. > > BUG=v8:5203 > > Review-Url: https://codereview.chromium.org/2650883002 > Cr-Commit-Position: refs/heads/master@{#43091} > Committed: https://chromium.googlesource.com/v8/v8/+/9346cd9b4c50466aa8d50e98c56b84ba47c2a115 [email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5203 Review-Url: https://codereview.chromium.org/2687973003 Cr-Commit-Position: refs/heads/master@{#43093}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Feb 28, 2017
…https://codereview.chromium.org/2695613004/ ) Reason for revert: Fails with nosse4: https://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20debug/builds/13853 Original issue's description: > Add several SIMD opcodes to IA32 > > CreateInt32x4, Int32x4ExtractLane, Int32x4ReplaceLane > Int32x4Add, Int32x4Sub > > Also add paddd and psubd to ia32-assembler > > BUG= > > Review-Url: https://codereview.chromium.org/2695613004 > Cr-Commit-Position: refs/heads/master@{#43483} > Committed: https://chromium.googlesource.com/v8/v8/+/4deb9ffdecf121c69a3db7eae6698eae23a80a15 [email protected],[email protected],[email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review-Url: https://codereview.chromium.org/2717423003 Cr-Commit-Position: refs/heads/master@{#43489}
hubot
pushed a commit
that referenced
this pull request
Mar 2, 2017
Revision: c776223 BUG=chromium:696651 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true [email protected] Review-Url: https://codereview.chromium.org/2727063005 . Cr-Commit-Position: refs/branch-heads/5.8@{#9} Cr-Branched-From: eda659c-refs/heads/5.8.283@{#1} Cr-Branched-From: 4310cd0-refs/heads/master@{#43429}
kisg
pushed a commit
to paul99/v8mips
that referenced
this pull request
Apr 6, 2017
…01 of https://codereview.chromium.org/2785293002/ ) Reason for revert: Seems to block roll: https://codereview.chromium.org/2801013002/ See also: https://build.chromium.org/p/client.v8.fyi/builders/Linux%20Tests%20%28dbg%29%281%29/builds/2731 Original issue's description: > [inspector] move console to builtins > > What will we get: > - console would be included into snapshot and allow us to reduce time that we spent in contextCreated function (~5 times faster), > - it allows us to make further small improvement of console methods, e.g. we can implement super quick return from console.assert if first argument is true, > - console calls are ~ 15% faster. > > BUG=v8:6175 > [email protected] > > Review-Url: https://codereview.chromium.org/2785293002 > Cr-Original-Original-Commit-Position: refs/heads/master@{#44353} > Committed: https://chromium.googlesource.com/v8/v8/+/55905f85d63d75aaa9313e51eb7bede754a8e41c > Review-Url: https://codereview.chromium.org/2785293002 > Cr-Original-Commit-Position: refs/heads/master@{#44355} > Committed: https://chromium.googlesource.com/v8/v8/+/cc74ea0bc4fe4a71fa53d08b62cc18d15e01fbb3 > Review-Url: https://codereview.chromium.org/2785293002 > Cr-Commit-Position: refs/heads/master@{#44416} > Committed: https://chromium.googlesource.com/v8/v8/+/f5dc738cda0336929dcb8eb73b87fdcd01b7c685 [email protected],[email protected] # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:6175 Review-Url: https://codereview.chromium.org/2801023003 Cr-Commit-Position: refs/heads/master@{#44429}
hubot
pushed a commit
that referenced
this pull request
Apr 6, 2017
Merged e4bb01b Revert of [inspector] move console to builtins (patchset #9 id:180001 of https://codereview.chromium.org/2785293002/ ) [email protected] BUG=v8:6175 LOG=N Change-Id: If44b9ed25601e41a897de5e0393e72e272a3c19d Reviewed-on: https://chromium-review.googlesource.com/469647 Reviewed-by: Michael Achenbach <[email protected]> Cr-Commit-Position: refs/heads/5.9.175@{#2} Cr-Branched-From: ba9fc3d-refs/heads/master@{#44422}
hubot
pushed a commit
that referenced
this pull request
Apr 13, 2017
…handler and Turbofan stubs. Revision: 53475ef NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true Change-Id: I2244c7e43bee6887b9049fb0046638cfc9e13e82 Reviewed-on: https://chromium-review.googlesource.com/476890 Reviewed-by: Leszek Swirski <[email protected]> Cr-Commit-Position: refs/branch-heads/5.9@{#9} Cr-Branched-From: fe9bb7e-refs/heads/5.9.211@{#1} Cr-Branched-From: 70ad237-refs/heads/master@{#44591}
hubot
pushed a commit
that referenced
this pull request
Apr 28, 2017
Merged 0902b5f Incorrect handling of HTransitionElementsKind in hydrogen check elimination phase fixed. BUG=chromium:460917 LOG=N [email protected] Review URL: https://codereview.chromium.org/1019033004 Cr-Commit-Position: refs/branch-heads/4.2@{#9} Cr-Branched-From: 3dfd929-refs/heads/4.2.77@{#2} Cr-Branched-From: e011092-refs/heads/master@{#26757}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
May 31, 2023
Merged b06a6a8 Revert "Make sure that memory reducer makes progress in incremental marking" [email protected] BUG=chromium:519319 NOTRY=true NOPRESUBMIT=true Review URL: https://codereview.chromium.org/1310613004 Cr-Commit-Position: refs/branch-heads/4.6@{v8#9} Cr-Branched-From: 24d34a8-refs/heads/4.6.85@{#1} Cr-Branched-From: 8f44118-refs/heads/master@{#30256}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jun 10, 2023
Change-Id: I1cc8ff4bd7a6cc0df12c7a4f9e419c8a4c4fa5ef Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4605048 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.5@{v8#9} Cr-Branched-From: 0c4044b-refs/heads/11.5.150@{#1} Cr-Branched-From: b71d303-refs/heads/main@{#87781}
patrik-lengweiler
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Jul 1, 2023
Change-Id: Ib69fab6e6e78dab648a3540adec17261b254c310 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4658181 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.6@{v8#9} Cr-Branched-From: e29c028-refs/heads/11.6.189@{v8#3} Cr-Branched-From: 95cbef2-refs/heads/main@{#88340}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Aug 27, 2023
Change-Id: I75f82cf0d3b7f9b02f9db6e820eb24591f6fe1c8 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4789347 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.7@{v8#9} Cr-Branched-From: fe60869-refs/heads/11.7.439@{#1} Cr-Branched-From: aeb4552-refs/heads/main@{#89415}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Sep 15, 2023
Change-Id: I30e8b7448a1232ea2450dba44ce726ac6c98ff4d Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4864311 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.8@{v8#9} Cr-Branched-From: 935bdbf-refs/heads/11.8.172@{#1} Cr-Branched-From: b82a911-refs/heads/main@{#89779}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Nov 19, 2023
Change-Id: Ia10275c75cf430a520b1c6ee792dca94039aaf54 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5029218 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.0@{v8#9} Cr-Branched-From: ed7b4ca-refs/heads/12.0.267@{#1} Cr-Branched-From: 210e75b-refs/heads/main@{#90651}
reposynch bot
pushed a commit
to hexagon-geo-surv/v8
that referenced
this pull request
Dec 10, 2023
Change-Id: I20d55dde899d712dab25adf51678bc54733e7d93 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5101333 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.1@{v8#9} Cr-Branched-From: b74ef6f-refs/heads/12.1.285@{#1} Cr-Branched-From: 32857fb-refs/heads/main@{#91313}
hubot
pushed a commit
that referenced
this pull request
Feb 27, 2024
Change-Id: Ie623731266b2b82f19dd7e69986a1ef12cbc7cc0 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5321997 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.3@{#9} Cr-Branched-From: a86e197-refs/heads/12.3.219@{#1} Cr-Branched-From: 21869f7-refs/heads/main@{#92385}
hubot
pushed a commit
that referenced
this pull request
Mar 22, 2024
Change-Id: Id168893d7bbdb731d5d24461e08183514e2ef635 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5388266 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.4@{#9} Cr-Branched-From: 309640d-refs/heads/12.4.254@{#1} Cr-Branched-From: 5dc2470-refs/heads/main@{#92862}
probablytom
pushed a commit
to probablytom/v8
that referenced
this pull request
Apr 11, 2024
Change-Id: I0fe203833d410072385fdfebf874f0ba09fa7936 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5237767 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.2@{v8#9} Cr-Branched-From: 6eb5a96-refs/heads/12.2.281@{#1} Cr-Branched-From: 44cf56d-refs/heads/main@{#91934}
hubot
pushed a commit
that referenced
this pull request
Apr 25, 2024
Change-Id: Ie12d70f212656ae086171adb214739b5d3cbbdb5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5488261 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.5@{#9} Cr-Branched-From: 15b9756-refs/heads/12.5.227@{#1} Cr-Branched-From: 497d857-refs/heads/main@{#93350}
hubot
pushed a commit
that referenced
this pull request
May 21, 2024
Change-Id: I86620a4e4985650cdcc258060c7bc1251fc03716 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5553151 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.6@{#9} Cr-Branched-From: 3c9fa12-refs/heads/12.6.228@{#2} Cr-Branched-From: 981bb15-refs/heads/main@{#93835}
hubot
pushed a commit
that referenced
this pull request
Jun 14, 2024
Change-Id: I159d7c40bca3cfff605e03e90884175f150a5128 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5630243 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.7@{#9} Cr-Branched-From: 35cc908-refs/heads/12.7.224@{#1} Cr-Branched-From: 6d60e67-refs/heads/main@{#94324}
hubot
pushed a commit
that referenced
this pull request
Aug 2, 2024
Change-Id: I105ea17d7155404889a7220d1f505d051aa74bf7 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5759379 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.8@{#9} Cr-Branched-From: 70cbb39-refs/heads/12.8.374@{#1} Cr-Branched-From: 451b63e-refs/heads/main@{#95151}
hubot
pushed a commit
that referenced
this pull request
Aug 26, 2024
Change-Id: I0113d0f9864af5e295f0da28d6bc507c36f79ea3 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5812171 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/12.9@{#9} Cr-Branched-From: 64a21d7-refs/heads/12.9.202@{#1} Cr-Branched-From: da4200b-refs/heads/main@{#95679}
CuiLam
pushed a commit
to CuiLam/v8
that referenced
this pull request
Sep 4, 2024
Change-Id: Ife1149fa8e2710c4e774538c239f5c04793ce729 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4953875 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/11.9@{v8#9} Cr-Branched-From: 3eb7d73-refs/heads/11.9.169@{#1} Cr-Branched-From: 1a13bf9-refs/heads/main@{#90218}
hubot
pushed a commit
that referenced
this pull request
Sep 20, 2024
Change-Id: Iab73679d3a9b3301174825f2fafe61ed9b253145 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5876686 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.0@{#9} Cr-Branched-From: 4be854b-refs/heads/13.0.245@{#1} Cr-Branched-From: 1f5183f-refs/heads/main@{#96103}
hubot
pushed a commit
that referenced
this pull request
Oct 24, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8733201801817212641 Change-Id: Ib61f2930eb2882246f83c6f51fa20c9ee0bb6b82 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5960258 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.1@{#9} Cr-Branched-From: 7998da6-refs/heads/13.1.201@{#1} Cr-Branched-From: 5e9af2a-refs/heads/main@{#96554}
hubot
pushed a commit
that referenced
this pull request
Nov 15, 2024
Version incremented at https://cr-buildbucket.appspot.com/build/8731194134123549089 Change-Id: I53c9f19d57b483ee6358c5c3907ec3b9d225f41f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6026048 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.2@{#9} Cr-Branched-From: 24068c5-refs/heads/13.2.152@{#1} Cr-Branched-From: 6054ba9-refs/heads/main@{#97085}
hubot
pushed a commit
that referenced
this pull request
Jan 10, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8726130330129296161 Change-Id: Ia03b88fb8277c46715a935b03809c94837c57e25 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6164109 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.3@{#9} Cr-Branched-From: 41dacff-refs/heads/13.3.415@{#1} Cr-Branched-From: 3348638-refs/heads/main@{#97937}
hubot
pushed a commit
that referenced
this pull request
Feb 7, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8723562282493790673 Change-Id: I87a00ef8c10f9132648fa1de55f3e777b3f6dbf2 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6244401 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.4@{#9} Cr-Branched-From: 0f87a54-refs/heads/13.4.114@{#1} Cr-Branched-From: 27af2e9-refs/heads/main@{#98459}
hubot
pushed a commit
that referenced
this pull request
Mar 11, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8720679035020666273 Change-Id: Ifcc02252558b5ce898d3505f884916360bf976ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6344092 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.5@{#9} Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1} Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
digitalhurricane-io
pushed a commit
to digitalhurricane-io/v8
that referenced
this pull request
Apr 2, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8720679035020666273 Change-Id: Ifcc02252558b5ce898d3505f884916360bf976ec Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6344092 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.5@{v8#9} Cr-Branched-From: c206c46-refs/heads/13.5.212@{#1} Cr-Branched-From: af3cadc-refs/heads/main@{#99020}
hubot
pushed a commit
that referenced
this pull request
Apr 10, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8717988872034416193 Change-Id: Ie46e2d1afb02ed878a4fad355e5d271a6c977702 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6445217 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.6@{#9} Cr-Branched-From: 04fa9cb-refs/heads/13.6.233@{#1} Cr-Branched-From: f6be482-refs/heads/main@{#99571}
hubot
pushed a commit
that referenced
this pull request
May 6, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8715625235767320753 Change-Id: I62552d72c5f521bcebd888aa5ef7b73b37959fe5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6512621 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.7@{#9} Cr-Branched-From: dd5370d-refs/heads/13.7.152@{#1} Cr-Branched-From: fa9b753-refs/heads/main@{#99927}
hubot
pushed a commit
that referenced
this pull request
May 29, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8713584537672014705 Change-Id: Ifad741f501bfeb4e53d722f90fb4deb469e6ed23 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6598285 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.8@{#9} Cr-Branched-From: 61ddd47-refs/heads/13.8.258@{#1} Cr-Branched-From: fdb5de2-refs/heads/main@{#100480}
hubot
pushed a commit
that referenced
this pull request
Jul 2, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8710430065291057201 Change-Id: I09ca0bdc5fd27e7ba2c65f810a3db7fccdf704dc Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6702087 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/13.9@{#9} Cr-Branched-From: 76ea409-refs/heads/13.9.205@{#1} Cr-Branched-From: 2824212-refs/heads/main@{#100941}
hubot
pushed a commit
that referenced
this pull request
Sep 12, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8703916520206699441 Change-Id: Ie99d1e1959114c8bffc48945a03b3b731c343e5f Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6943114 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.0@{#9} Cr-Branched-From: 4ec2f43-refs/heads/14.0.365@{#1} Cr-Branched-From: a88b570-refs/heads/main@{#101731}
hubot
pushed a commit
that referenced
this pull request
Sep 16, 2025
Version incremented at https://cr-buildbucket.appspot.com/build/8703544694388415713 Change-Id: I03e0f176a0404f67534d76b4028bb77ff3c78f33 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6954994 Bot-Commit: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/branch-heads/14.1@{#9} Cr-Branched-From: 1f4839b-refs/heads/14.1.146@{#1} Cr-Branched-From: cd6944c-refs/heads/main@{#102149}
hubot
pushed a commit
that referenced
this pull request
Oct 8, 2025
Original change's description: > [heap] Make CheckIneffectiveMarkCompact late > > This CL implements similar behavior as late_heap_limit_check > for CheckIneffectiveMarkCompact behind ineffective_gcs_forces_last_resort: > such that the check happens only once after CollectAllAvailableGarbage. > This makes is less likely to trigger "Ineffective mark-compacts" > OOM within the retry loop - crash data shows this is by far > the leading cause of "Ineffective mark-compacts". > > Bug: 448848875 > Change-Id: Ifff197abaa31de6e4c3b70ca8428d63f99670958 > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7002802 > Reviewed-by: Dominik Inführ <[email protected]> > Commit-Queue: Etienne Pierre-Doray <[email protected]> > Cr-Commit-Position: refs/heads/main@{#102973} (cherry picked from commit 3259e0a) Bug: 450245787,448848875 Change-Id: Ifff197abaa31de6e4c3b70ca8428d63f99670958 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7023050 Auto-Submit: Chrome Cherry Picker <chrome-cherry-picker@chops-service-accounts.iam.gserviceaccount.com> Bot-Commit: Rubber Stamper <[email protected]> Commit-Queue: Rubber Stamper <[email protected]> Cr-Commit-Position: refs/branch-heads/14.2@{#9} Cr-Branched-From: 37f82db-refs/heads/14.2.231@{#1} Cr-Branched-From: d1a6089-refs/heads/main@{#102804}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a stage 3 proposal waiting to be implemented in at least two browsers in order to make it to stage 4.
Tests has been submitted to test262 by the champion ( @ljharb ) so the last bit would be to actually implement it in core.
These changes have been successfully tested already after a clean
make nativeand double-verified manually within d8 console itself.Thanks in advance for considering this PR or for clarifying what else is needed in order to integrate such proposal.
Best Regards