Replace vugu/js with syscall/js on GOOS=js GOARCH=wasm platforms
#7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrades Go 1.14 => 1.22.3 toolchain => go1.24.2 (new) github.com/vugu/html (new) github.com/vugu/xxhash (new) github.com/davecgh/go-spew 1.1.0 => 1.1.1 github.com/pmezard/go-difflib 1.0.0 (new) github.com/stretchr/testify 1.4.0 => 1.10.0 gopkg.in/yaml.v2 2.2.2 => gopkg.in/yaml.v3 3.0.1
The test TestFull in rgen_test.go dynamically creates a go test file and a go.mod file in a tmp directory. The test fails because the dependency github.com/vugu/[email protected] is not available, but is required (after the dependency updates). The test has been updated so that it now downloads github.com/vugu/vugu@master - note it always uses the master branch and then calls go mod tidy to update the go.mod and go.sum. The test then passes.
As per PR 354 on vugu vugu/vugu#354 This commit makes a similar change to the vgrouter. For GOOS=js and GOARCH=wasm targets the code builds against syscall/js and not github.com/vugu/vugu/js. For all other targets github.com/vugu/vugu/js is still used. All of the tests still pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per PR #354 on
vuguvugu/vugu#354
This commit makes a similar change to the
vgrouter.For
GOOS=jsandGOARCH=wasmtargets the code builds againstsyscall/jsand notgithub.com/vugu/vugu/js.For all other targets
github.com/vugu/vugu/jsis still used.All of the tests still pass.