Conversation
|
hi @BobbieGoede can you pre-review this, and give me some advice? |
commit: |
|
Sorry again for the delays in reviewing this PR is a bit more involved and I'm contributing on several projects at the same timeπ My initial thoughts:
Please let me know if more clarification is needed π Contributions are always appreciated, just making sure we preserve maintainability when adding more functionality πͺ |
|
thanks a lot π i saw the code now i use export interface SVGPathProperties {
pathLength?: number
pathOffset?: number
pathSpacing?: number
}but like |
π Linked issue
#241
β Type of change
π Description
SVGPath related properties are not processed originally
MotionPropertiesis defined includesSVGPathProperties, but does not processstylesupports processpathLength,pathSpacing,pathOffsetpathLengthalways normalize to 1pathLengthandpathSpacingtostroke-dasharray.stroke-dasharray = pathLength pathSpacing4.1
stroke-dasharray = pathLength pathSpacing. this support process dashes and gaps are two or same size, can't process that dashes and gaps of various sizes with an odd number of values, like4,1,2which is equivalent to[4,1,2,4,1,2]pathOffsettostroke-dashoffsetπ Checklist