Empty responses should not be compressed #3364
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This behavior is correct according to spec. Empty responses should be returned using response code I just went through this same thought process about two weeks ago—that's where I ended up 😅. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When returning empty responses, such as
Response(status: .ok)and the browser has sentAccept-Encoding: gzip, deflate, br, zstdheaders, Vapor should not compress responses.When compression is enabled on empty responses, some compression encodings, such as
deflate, end up returning 8 bytes of data, so the final response that the browser receives hasContent-Length == 8, but with no body. This ends up erroring withnet::ERR_CONTENT_LENGTH_MISMATCHon the browser side.