Replace CGI.parse with URI.decode_www_form for Ruby 3.5+ compatibility
#1059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1057. Ruby 3.5 removed CGI from the standard library, causing VCR to fail when using CGI.parse for query parsing. Adding cgi as an explicit runtime dependency ensures compatibility across Ruby versions.
Uses standard library URI.decode_www_form instead of requiring external cgi dependency. Maintains identical API by converting array format to the expected hash-of-arrays format that CGI.parse provides. Fixes #1057
CGI.parse with URI.decode_www_form for Ruby 3.5+ compatibility
|
I've updated this PR with an alternative solution that avoids adding any external dependencies. Instead of adding Changes:
This approach is more future-proof and doesn't introduce any new gem dependencies to the project. If we would rather just add it as a dependancy though, I can't roll this PR back to the original commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
cgias an explicit runtime dependency to fix compatibility with Ruby 3.5+Problem
Ruby 3.5 removed CGI from the standard library, causing VCR to fail with:
undefined method 'parse' for class '#Class:CGI'This occurs because VCR uses
CGI.method(:parse)inlib/vcr/configuration.rb:505for query string parsing.Solution
Added
spec.add_runtime_dependency 'cgi'tovcr.gemspecto ensure the CGI library is available across all supported Ruby versions.Test plan
gem build vcr.gemspecFixes #1057