fix(okta): Source does not update since query every interval
#24053
+404
−444
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, the Okta source component does not function as expected. Vector never updates the
sinceAPI query parameter to bring in a new window of Okta logs; the staticsincevalue means that the window only grows and grows with each interval. Additionally, because anuntilparameter is never provided, the Okta API always includes header links in the response instead of only on pagination. This leads to scenarios where Vector will quickly hit the Okta API rate limit.This PR thus makes the following changes:
sincequery every interval to bring in new logs.This is my first PR to Vector, and I'm very open to feedback! 😄
I associated this PR to an existing closed issue, where another PR started the Okta work. In building on top of that work, if it is more prudent to open a separate issue for what I'm seeing above, I'm happy to knock that out as well.
I did my best in trying to preserve the original intent with the
sinceargument, but I wasn't able to find my way towards a better implementation with the structure of the code as-is. I'm open to suggestions as to how to make this component feel more "Vector-native"!Furthermore, it is worth disclosing that no AI tools were used in the development of this PR.
Vector configuration
How did you test this PR?
I built Vector and used the above configuration, alongside the
VECTOR_LOG=debugflag, to diagnose and troubleshoot failures with the Okta source. For other components, I ran the test suite.All changes have been human-tested with a release build of this branch against a live Okta environment.
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References
Notes
@vectordotdev/vectorto reach out to us regarding this PR.pre-pushhook, please see this template.make fmtmake check-clippy(if there are failures it's possible some of them can be fixed withmake clippy-fix)make testgit merge origin masterandgit push.Cargo.lock), pleaserun
make build-licensesto regenerate the license inventory and commit the changes (if any). More details here.