Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented Oct 20, 2025

There's no easy way to tell why the numbers in the original assertion would change. By having the textual rendering of what got logged it's easier to see why it changes when the telemetry API changes affect it.

Uses pretty-assertions because that has a good multiline string diff rendering.

@Nemo157
Copy link
Contributor Author

Nemo157 commented Oct 20, 2025

(Extracted from #67)

@claude
Copy link

claude bot commented Oct 20, 2025

Change Summary

This PR improves the test_trailing_comma_support test by replacing a simple count assertion with a full structure verification using format_telemetry_tree.
The change adds pretty_assertions as a dev dependency to provide better diff output when the assertion fails.
This makes it easier to identify when telemetry API changes affect the output structure.


✅ Review complete - no issues found

@Nemo157 Nemo157 enabled auto-merge October 20, 2025 14:56
@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Nemo157 Nemo157 added this pull request to the merge queue Oct 20, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 20, 2025
@vE5li vE5li added this pull request to the merge queue Oct 20, 2025
Merged via the queue into main with commit ab08742 Oct 20, 2025
26 checks passed
@vE5li vE5li deleted the wim/push-wnuosqqxylsn branch October 20, 2025 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants