Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(telemetry)!: replace execution id with thread id #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(telemetry)!: replace execution id with thread id #90

wants to merge 1 commit into from

Conversation

@Nemo157
Copy link
Contributor

@Nemo157 Nemo157 commented Oct 21, 2025 •
edited
Loading

The collector is now initialized with a process id and automatically combines this with a per-thread id from the OSAL to create a globally unique id for the current thread/task.

Closes: DEV-913

Nemo157
Nemo157 commented Oct 21, 2025
View reviewed changes
@github-actions
Copy link

github-actions bot commented Oct 21, 2025 •
edited
Loading

Deployment - Branch link Commit link - 0b754a0
user-manual preview https://2dbdbf4f.user-manual-2bd.pages.dev
private-docs preview https://ca111a79.private-docs-3bh.pages.dev
veecle-telemetry-ui preview https://03465f53.veecle-telemetry-ui.pages.dev

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Nemo157 Nemo157 requested a review from arctic-alpaca October 21, 2025 14:31
@Nemo157 Nemo157 marked this pull request as ready for review October 21, 2025 14:31
@claude
Copy link

claude bot commented Oct 21, 2025

Change Summary

This PR refactors the telemetry execution ID system to include both process and thread identifiers.
The ExecutionId type is changed from a simple u128 wrapper to a struct containing a ProcessId and ThreadId, enabling unique identification of thread/task combinations.
The ProcessId type (formerly the full ExecutionId) is extracted into a separate type, and thread IDs are now automatically captured when creating telemetry messages.
All examples and tests are updated to use ProcessId::random() instead of ExecutionId::random().

Issues Found

🟡 Documentation Grammar Issues

The documentation for set_exporter in veecle-telemetry/src/collector/mod.rs:156 contains a grammatical error: "An [ProcessId]" should be "A [ProcessId]" (using the article "A" instead of "An" since "ProcessId" starts with a consonant sound).

claude[bot]
claude bot reviewed Oct 21, 2025
View reviewed changes
arctic-alpaca
arctic-alpaca reviewed Oct 21, 2025
View reviewed changes
arctic-alpaca
arctic-alpaca previously approved these changes Oct 21, 2025
View reviewed changes
@Nemo157 Nemo157 force-pushed the wim/push-xtrxyrmwrwvn branch 3 times, most recently from 0a40420 to 6ff2102 Compare October 22, 2025 12:42
@Nemo157 Nemo157 changed the title feat(telemetry)!: add thread id to execution id feat(telemetry)!: replace execution id with thread id Oct 22, 2025
@arctic-alpaca arctic-alpaca self-requested a review October 22, 2025 12:48
@arctic-alpaca arctic-alpaca dismissed their stale review October 22, 2025 12:49

Refactor of PR.

arctic-alpaca
arctic-alpaca reviewed Oct 22, 2025
View reviewed changes
arctic-alpaca
arctic-alpaca reviewed Oct 22, 2025
View reviewed changes
@Nemo157 Nemo157 mentioned this pull request Oct 23, 2025
Closed
@Nemo157 Nemo157 force-pushed the wim/push-xtrxyrmwrwvn branch 3 times, most recently from 2969fa9 to a13a0bb Compare October 23, 2025 11:05
@Nemo157
feat(telemetry)!: replace execution id with thread id
4ce79f3 
The collector is now initialized with a process id and automatically
combines this with a per-thread id from the OSAL to create a globally
unique id for the current thread/task.

Closes: DEV-913
Signed-off-by: Wim Looman <[email protected]>
@Nemo157 Nemo157 force-pushed the wim/push-xtrxyrmwrwvn branch from a13a0bb to 4ce79f3 Compare October 23, 2025 11:13
@vertexclique
Copy link

Seems like we will keep ids separate so it is ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@claude claude[bot] claude[bot] left review comments

@vertexclique vertexclique vertexclique approved these changes

@arctic-alpaca arctic-alpaca arctic-alpaca approved these changes

@ForsakenHarmony ForsakenHarmony Awaiting requested review from ForsakenHarmony ForsakenHarmony is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Nemo157 @vertexclique @arctic-alpaca