Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@vernu
Copy link
Owner

@vernu vernu commented Apr 5, 2025

No description provided.

@vernu vernu requested a review from Copilot April 5, 2025 11:52
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/build-and-test.yaml:98

  • The Android tests step is commented out; consider enabling or removing these lines to ensure the workflow clearly reflects intended test coverage.
# - name: Run Android tests

.github/workflows/build-and-test.yaml:20

  • [nitpick] The renamed job 'build-and-test-web-and-api' should accurately reflect its purpose; verify that this new name aligns with its responsibilities in the workflow.
build-and-test-web-and-api:

@vernu vernu requested a review from Copilot April 5, 2025 12:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

.github/workflows/build-and-test.yaml:76

  • [nitpick] Consider refactoring the conditional expression for branch selection to improve readability, for example using the ternary operator: ${{ github.event_name == 'workflow_dispatch' ? inputs.branch : github.ref }}.
ref: ${{ github.event_name == 'workflow_dispatch' && inputs.branch || github.ref }}

.github/workflows/build-and-test.yaml:98

  • [nitpick] If Android tests are available, consider uncommenting and configuring this test step to ensure the Android build is adequately verified.
      # - name: Run Android tests

@vernu vernu merged commit b57bced into main Apr 5, 2025
2 checks passed
@vernu vernu deleted the build-android branch April 5, 2025 12:00
selamawitk pushed a commit to selamawitk/textbee that referenced this pull request Sep 7, 2025
build android debug artifacts on push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants