Upload NCC Public Report #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@kevin-henry-ncc, can we get the DCO issue fixed? Always ironic that PRs on a signing repo aren't signed :) |
yogeshbdeshpande
approved these changes
Jun 11, 2022
Contributor
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
I thought we agreed that NCC Auditors will create a PR for this ?
Anyway, if you have already discussed with them and then submitting, I am happy about it and hence approving the PR!
Contributor
|
Ah, Thank you. I noticed that now! Look good to me! |
thomas-fossati
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A copy of the public report published at https://research.nccgroup.com/2022/05/26/public-report-go-cose-security-assessment/