Reduce FuzzSign1 memory consumption #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: qmuntal <[email protected]>
21af3d4 to
92770b7
Compare
Codecov Report
@@ Coverage Diff @@
## main #104 +/- ##
==========================================
+ Coverage 89.74% 92.10% +2.35%
==========================================
Files 10 10
Lines 985 975 -10
==========================================
+ Hits 884 898 +14
+ Misses 67 51 -16
+ Partials 34 26 -8
π£ Weβre building smart automated test selection to slash your CI/CD build times. Learn more |
yogeshbdeshpande
approved these changes
Sep 27, 2022
Contributor
yogeshbdeshpande
left a comment
There was a problem hiding this comment.
LGTM!
(Apologies for the delay)
Member
Author
|
This is ready to merge, I don't have write access in this repo π |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces the memory consumption of
FuzzSign1by creating the necessary signers and verifiers before actually executing the fuzz target instead of creating a new set on every execution.This fuzz test in particular is causing intermitent failures in an internal pipeline we (the Microsoft Go team) run nightly, and the error is always associated to the host killing the fuzzing execution due to an elevated memory consumption.
@thomas-fossati @shizhMSFT @yogeshbdeshpande