feat(provider/anthropic): Url support for pdfs and images in tool results #9733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Collaborator
|
Lots of lines changed, can you try reverting the lockfile? |
lgrammel
reviewed
Oct 23, 2025
Collaborator
|
changes look good for v6 |
Contributor
Author
|
@lgrammel All done |
Collaborator
|
@nlaz can you allow changes by maintainers on this PR? i want to make a few minor tweaks to the tests |
lgrammel
reviewed
Oct 23, 2025
packages/anthropic/src/convert-to-anthropic-messages-prompt.test.ts
Outdated
Show resolved
Hide resolved
lgrammel
reviewed
Oct 23, 2025
packages/anthropic/src/convert-to-anthropic-messages-prompt.test.ts
Outdated
Show resolved
Hide resolved
lgrammel
reviewed
Oct 23, 2025
packages/anthropic/src/convert-to-anthropic-messages-prompt.test.ts
Outdated
Show resolved
Hide resolved
Collaborator
|
Or you can update the test file. Ideally in the future edits by maintainers would be allowed. |
Contributor
Author
|
Test has been updated. I don't have the option in GH to open it up to edit by maintainers. Maybe its because the fork was made on a org account. Will try PRs via personal account in the future |
lgrammel
approved these changes
Oct 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Now that v6 has
image-urlandfile-urlthis makes it simple to support pdfs and images in the anthropic tool results blocks.This PR adds support for url-based PDFs in tool results. This is a pretty common way to fetch and insert PDF without blowing up the context window. Anthropic's API handles this out of the box. Just needed to update the types on the tool result handling.
Summary
Uses the
image-urlandfile-urltypes to send urls to the provider.Manual Verification
Used the example files to verify the functionality.
Checklist
pnpm changesetin the project root)Related Issues
Hacky Backport: #9503
Related: #9041
Fixes #8014