Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add ConnectionPool.removeUnused. #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-ludwig merged 1 commit into from
Mar 29, 2019
Merged

Add ConnectionPool.removeUnused. #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions source/vibe/core/connectionpool.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,28 @@ final class ConnectionPool(Connection)
auto ret = LockedConnection!Connection(this, conn);
return ret;
}

/** Removes all currently unlocked connections from the pool.

Params:
disconnect_callback = Gets called for every removed connection to
allow closing connections and freeing associated resources.
*/
void removeUnused(scope void delegate(Connection conn) @safe nothrow disconnect_callback)
{
Connection[] remaining_conns, removed_conns;
foreach (c; m_connections) {
if (m_lockCount.get(c, 0) > 0)
remaining_conns ~= c;
else
removed_conns ~= c;
}

m_connections = remaining_conns;

foreach (c; removed_conns)
disconnect_callback(c);
}
}

///
Expand Down Expand Up @@ -137,6 +159,31 @@ unittest { // issue vibe-d#2109
new ConnectionPool!TCPConnection({ return connectTCP("127.0.0.1", 8080); });
}

unittest { // removeUnused
class Connection {}

auto pool = new ConnectionPool!Connection({
return new Connection; // perform the connection here
});

auto c1 = pool.lockConnection();
auto c1i = c1.__conn;

auto c2 = pool.lockConnection();
auto c2i = c2.__conn;


assert(pool.m_connections == [c1i, c2i]);

c2 = LockedConnection!Connection.init;
pool.removeUnused((c) { assert(c is c2i); });
assert(pool.m_connections == [c1i]);

c1 = LockedConnection!Connection.init;
pool.removeUnused((c) { assert(c is c1i); });
assert(pool.m_connections == []);
}


struct LockedConnection(Connection) {
import vibe.core.task : Task;
Expand Down