Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: Broken menu button setIcon type #9089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Broken menu button setIcon type #9089

wants to merge 1 commit into from

Conversation

@Chocobozzz
Copy link
Contributor

@Chocobozzz Chocobozzz commented Aug 12, 2025 •
edited
Loading

Description

Prevent

Property 'setIcon' in type 'MenuButton' is not assignable to the same property in base type 'Component'.
  Type '(name: string) => void' is not assignable to type '(iconName: string, el?: Element) => Element'.
    Type 'void' is not assignable to type 'Element'.

71     setIcon(name: string): void;

Typescript error

Specific Changes proposed

Fix typings

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Aug 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.92%. Comparing base (8e4ec97) to head (5a8e8c9).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #9089      +/-   ##
==========================================
+ Coverage   84.31%   84.92%   +0.61%     
==========================================
  Files         120      120              
  Lines        8154     8154              
  Branches     1964     1964              
==========================================
+ Hits         6875     6925      +50     
+ Misses       1279     1229      -50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Chocobozzz added a commit to Chocobozzz/PeerTube that referenced this pull request Sep 12, 2025
@Chocobozzz
Patch video.js types to unbreak the build
f93870e 
Remove the patch when videojs/video.js#9089 is
published
jeffy53
jeffy53 suggested changes Oct 24, 2025
View reviewed changes
Copy link

@jeffy53 jeffy53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jeffy53 jeffy53 jeffy53 requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Chocobozzz @jeffy53