fix(track-button): properly remove event listeners on dispose to prevent leaks and runtime errors #9101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a memory leak issue in the
TrackButtoncomponent.Currently,
TrackButtonattaches event listeners toTextTrackListand the player instance, but only removes some of them when the player is disposed. If aTrackButtoninstance itself is disposed (e.g. when custom text tracks are removed/added dynamically), the listeners remain active, causing stale references and potential leaks.The issue was noticed when dynamically removing and adding text tracks in
CaptionsButtonorTrackButtoncomponents — old listeners were not cleaned up, leading to unexpected behavior, memory usage growth and errors likemain.js:1685 VIDEOJS: ERROR: Error: Invalid target for null#on; must be a DOM node or evented object..Specific Changes proposed
updateHandleranddisposeHandleras private properties (this.updateHandler_,this.disposeHandler_).dispose()to:TextTrackListand the player.delete this.updateHandler_,delete this.disposeHandler_).super.dispose()afterwards.Requirements Checklist
dispose())