win32: Fix a flaky test Test_terminal_shell_option #6557
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cygwin/MSYS2 provides dir.exe, and if it existed in the %PATH%, "term dir" succeeded unintentionally. That can make the test flaky. Use dir.com instead of dir to fix this. "term dir.com" should fail. (Assuming dir.com doesn't exist.) "term ++shell dir.com" should execute the dir builtin command even with the extension ".com".
zeertzjq
added a commit
to zeertzjq/neovim
that referenced
this pull request
Aug 22, 2023
…uffer
Problem: The cursor line number becomes negative when using :z^ in an empty
buffer. (neovim vim/vim#6557)
Solution: Correct the line number. Also reset the column.
vim/vim@a364cdb
Co-authored-by: Bram Moolenaar <[email protected]>
zeertzjq
added a commit
to neovim/neovim
that referenced
this pull request
Aug 22, 2023
…uffer (#24836) Problem: The cursor line number becomes negative when using :z^ in an empty buffer. (neovim vim/vim#6557) Solution: Correct the line number. Also reset the column. vim/vim@a364cdb Co-authored-by: Bram Moolenaar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cygwin/MSYS2 provides dir.exe, and if it existed in the %PATH%,
"term dir" succeeded unintentionally. That can make the test flaky.
Use dir.com instead of dir to fix this.
"term dir.com" should fail. (Assuming dir.com doesn't exist.)
"term ++shell dir.com" should execute the dir builtin command even with
the extension ".com".