Thanks to visit codestin.com
Credit goes to github.com

Skip to content

'statusline' is disable with builtin error which is caught correctly #729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

'statusline' is disable with builtin error which is caught correctly #729

wants to merge 5 commits into from

Conversation

@haya14busa
Copy link
Contributor

Hi

Problem

'statusline' is disable with builtin error which is cathced correctly

How To Reproduce

statusline_test.vimrc
set nocompatible

function! StatuslineKiller() abort
  try
    call eval('error!')
  catch
    return 'OK: error catched!'
  endtry
  return 'OK'
endfunction

set laststatus=2
set statusline=%{StatuslineKiller()}
  1. vim -u statusline_test.vimrc -i NONE -N
    • statusline shows 'OK: error catched!'
  2. :redrawstatus
    • " Press ENTER or type command to continue
    • Press <Enter>
    • statusline is disable (&statusline == '')

Expected

  1. vim -u statusline_test.vimrc -i NONE -N
  • statusline shows 'OK: error catched!'
  1. :redrawstatus
    • statusline shows 'OK: error catched!'

I fixed this problem and also added tests. Please include it.

Thanks.

@haya14busa
Do not disable statusline with catched error
0cd2c2f 
Instead, we should check did_emsg (which I assume is an error actually
occur) and disable statusline and show an error message as well.
@haya14busa
save and restore did_emsg
41fcccf
@haya14busa
add test
15ee4eb
@haya14busa
Make it clear to throw error
7564ec7
@haya14busa haya14busa mentioned this pull request Apr 4, 2016
Closed
h-east
h-east reviewed Apr 4, 2016
View reviewed changes
src/testdir/test_statusline.vim Outdated
return ''
endfunction

function! Test_cached_error_in_statusline()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/cached/catched/

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also in the title of this pull request

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be "caught".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 I fixed it.

@haya14busa haya14busa changed the title 'statusline' is disable with builtin error which is cathced correctly 'statusline' is disable with builtin error which is caught correctly Apr 4, 2016
@brammool brammool closed this in a742e08 Apr 5, 2016
@haya14busa
Copy link
Contributor Author

Thanks 👍

micbou added a commit to micbou/vim that referenced this pull request Apr 5, 2016
@micbou
Bump version to 7.4.1714
80e9092 
- 7.4.1711: when using try/catch in 'statusline' it is still considered
  an error and the status line will be disabled. Check did_emsg instead
  of called_emsg. (haya14busa, closes vim#729)
- 7.4.1712: for plugins in packages, plugin authors need to take care of
  all dependencies. When loading "start" packages and for :packloadall,
  first add all directories to 'runtimepath' before sourcing plugins.
- 7.4.1713: gTK GUI doesn't work on Wayland. Specify that only the X11
  backend is allowed. (Simon McVittie)
- 7.4.1714: non-GUI specific settings in the gvimrc_example file. Move
  some settings to the vimrc_example file. Remove setting 'hlsearch'
  again. (suggested by Hirohito Higashi)
micbou added a commit to micbou/vim that referenced this pull request Apr 5, 2016
@micbou
Bump version to 7.4.1714
4dbc35d 
- 7.4.1711: When using try/catch in 'statusline' it is still considered
  an error and the status line will be disabled. Check did_emsg instead
  of called_emsg. (haya14busa, closes vim#729)
- 7.4.1712: For plugins in packages, plugin authors need to take care of
  all dependencies. When loading "start" packages and for :packloadall,
  first add all directories to 'runtimepath' before sourcing plugins.
- 7.4.1713: GTK GUI doesn't work on Wayland. Specify that only the X11
  backend is allowed. (Simon McVittie)
- 7.4.1714: Non-GUI specific settings in the gvimrc_example file. Move
  some settings to the vimrc_example file. Remove setting 'hlsearch'
  again. (suggested by Hirohito Higashi)
micbou added a commit to micbou/vim that referenced this pull request Apr 5, 2016
@micbou
Bump version to 7.4.1714
35082cd 
- 7.4.1711: When using try/catch in 'statusline' it is still considered
  an error and the status line will be disabled. Check did_emsg instead
  of called_emsg. (haya14busa, closes vim#729)
- 7.4.1712: For plugins in packages, plugin authors need to take care of
  all dependencies. When loading "start" packages and for :packloadall,
  first add all directories to 'runtimepath' before sourcing plugins.
- 7.4.1713: GTK GUI doesn't work on Wayland. Specify that only the X11
  backend is allowed. (Simon McVittie)
- 7.4.1714: Non-GUI specific settings in the gvimrc_example file. Move
  some settings to the vimrc_example file. Remove setting 'hlsearch'
  again. (suggested by Hirohito Higashi)
micbou added a commit to micbou/vim that referenced this pull request Apr 5, 2016
@micbou
Bump version to 7.4.1714
c227fca 
- 7.4.1711: When using try/catch in 'statusline' it is still considered
  an error and the status line will be disabled. Check did_emsg instead
  of called_emsg. (haya14busa, closes vim#729)
- 7.4.1712: For plugins in packages, plugin authors need to take care of
  all dependencies. When loading "start" packages and for :packloadall,
  first add all directories to 'runtimepath' before sourcing plugins.
- 7.4.1713: GTK GUI doesn't work on Wayland. Specify that only the X11
  backend is allowed. (Simon McVittie)
- 7.4.1714: Non-GUI specific settings in the gvimrc_example file. Move
  some settings to the vimrc_example file. Remove setting 'hlsearch'
  again. (suggested by Hirohito Higashi)
micbou added a commit to micbou/vim that referenced this pull request Apr 5, 2016
@micbou
Bump version to 7.4.1714
f7b16da 
- 7.4.1711: When using try/catch in 'statusline' it is still considered
  an error and the status line will be disabled. Check did_emsg instead
  of called_emsg. (haya14busa, closes vim#729)
- 7.4.1712: For plugins in packages, plugin authors need to take care of
  all dependencies. When loading "start" packages and for :packloadall,
  first add all directories to 'runtimepath' before sourcing plugins.
- 7.4.1713: GTK GUI doesn't work on Wayland. Specify that only the X11
  backend is allowed. (Simon McVittie)
- 7.4.1714: Non-GUI specific settings in the gvimrc_example file. Move
  some settings to the vimrc_example file. Remove setting 'hlsearch'
  again. (suggested by Hirohito Higashi)
micbou added a commit to micbou/vim that referenced this pull request Apr 5, 2016
@micbou
Bump version to 7.4.1714
3495bde 
- 7.4.1711: When using try/catch in 'statusline' it is still considered
  an error and the status line will be disabled. Check did_emsg instead
  of called_emsg. (haya14busa, closes vim#729)
- 7.4.1712: For plugins in packages, plugin authors need to take care of
  all dependencies. When loading "start" packages and for :packloadall,
  first add all directories to 'runtimepath' before sourcing plugins.
- 7.4.1713: GTK GUI doesn't work on Wayland. Specify that only the X11
  backend is allowed. (Simon McVittie)
- 7.4.1714: Non-GUI specific settings in the gvimrc_example file. Move
  some settings to the vimrc_example file. Remove setting 'hlsearch'
  again. (suggested by Hirohito Higashi)
micbou added a commit to micbou/vim that referenced this pull request Apr 6, 2016
@micbou
Bump version to 7.4.1714
956dc78 
- 7.4.1711: When using try/catch in 'statusline' it is still considered
  an error and the status line will be disabled. Check did_emsg instead
  of called_emsg. (haya14busa, closes vim#729)
- 7.4.1712: For plugins in packages, plugin authors need to take care of
  all dependencies. When loading "start" packages and for :packloadall,
  first add all directories to 'runtimepath' before sourcing plugins.
- 7.4.1713: GTK GUI doesn't work on Wayland. Specify that only the X11
  backend is allowed. (Simon McVittie)
- 7.4.1714: Non-GUI specific settings in the gvimrc_example file. Move
  some settings to the vimrc_example file. Remove setting 'hlsearch'
  again. (suggested by Hirohito Higashi)
haya14busa pushed a commit to haya14busa/vim that referenced this pull request Apr 9, 2016
@brammool @haya14busa
patch 7.4.1711
f76df1e 
Problem:    When using try/catch in 'statusline' it is still considered an
            error and the status line will be disabled.
Solution:   Check did_emsg instead of called_emsg. (haya14busa, closes vim#729)
This was referenced Apr 10, 2016
Closed
Open
brcolow added a commit to brcolow/neovim that referenced this pull request Nov 25, 2016
@brcolow
vim-patch:7.4.1711
66d413a 
Problem:    When using try/catch in 'statusline' it is still considered an
            error and the status line will be disabled.
Solution:   Check did_emsg instead of called_emsg. (haya14busa, closes vim/vim#729)

vim/vim@a742e08
@brcolow brcolow mentioned this pull request Nov 25, 2016
Merged
brcolow added a commit to brcolow/neovim that referenced this pull request Nov 26, 2016
@brcolow
vim-patch:7.4.1711
22c7dbd 
Problem:    When using try/catch in 'statusline' it is still considered an
            error and the status line will be disabled.
Solution:   Check did_emsg instead of called_emsg. (haya14busa, closes vim/vim#729)

vim/vim@a742e08
@haya14busa haya14busa deleted the fix-redrawstatusline-for-catched-error branch November 3, 2017 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@haya14busa @itchyny @h-east @k-takata