Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@dpelle
Copy link
Member

@dpelle dpelle commented Feb 27, 2021

This PR should improve test coverage of text properties.
So errors paths were not covered.

@codecov
Copy link

codecov bot commented Feb 27, 2021

Codecov Report

Merging #7908 (1935c5a) into master (087b5ff) will decrease coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7908      +/-   ##
==========================================
- Coverage   89.06%   88.93%   -0.14%     
==========================================
  Files         148      148              
  Lines      165110   162553    -2557     
==========================================
- Hits       147058   144569    -2489     
+ Misses      18052    17984      -68     
Flag Coverage Δ
huge-clang-none 80.44% <ø> (-7.77%) ⬇️
huge-gcc-none 88.54% <ø> (+<0.01%) ⬆️
huge-gcc-testgui 87.04% <ø> (+0.01%) ⬆️
huge-gcc-unittests 2.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/help.c 89.76% <0.00%> (-1.08%) ⬇️
src/os_unix.c 70.56% <0.00%> (-0.98%) ⬇️
src/textobject.c 91.69% <0.00%> (-0.71%) ⬇️
src/if_python.c 82.65% <0.00%> (-0.62%) ⬇️
src/profiler.c 93.29% <0.00%> (-0.61%) ⬇️
src/ops.c 91.80% <0.00%> (-0.57%) ⬇️
src/screen.c 85.44% <0.00%> (-0.55%) ⬇️
src/ex_cmds2.c 90.68% <0.00%> (-0.54%) ⬇️
src/move.c 93.77% <0.00%> (-0.54%) ⬇️
src/search.c 92.03% <0.00%> (-0.53%) ⬇️
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 087b5ff...d34aed3. Read the comment docs.

@brammool brammool closed this in 3dc3474 Mar 2, 2021
VVKot added a commit to VVKot/neovim that referenced this pull request Mar 28, 2021
Problem:    Plural messages are not translated properly.
Solution:   Add more usage of NGETTEXT(). (Sergey Alyoshin)
vim/vim@da6e891

N/A patches for textprop:

vim-patch:8.1.0579: cannot attach properties to text

Problem:    Cannot attach properties to text.
Solution:   First part of adding text properties.
vim/vim@98aefe7

vim-patch:8.1.0667: textprop test leaves file behind

Problem:    Textprop test leaves file behind.
Solution:   Delete the file. (Dominique Pelle, closes vim/vim#3743)
vim/vim@2f21fa8

vim-patch:8.1.0676: textprop screendump test fails

Problem:    Textprop screendump test fails.
Solution:   Add missing changes.
vim/vim@5e53ac0

vim-patch:8.1.1278: missing change for "combine" field

Problem:    Missing change for "combine" field.
Solution:   Also change the textprop implementation.
vim/vim@58187f1

vim-patch:8.1.1340: attributes from 'cursorline' overwrite textprop

Problem:    Attributes from 'cursorline' overwrite textprop.
Solution:   Combine the attributes. (closes vim/vim#3912)
vim/vim@bfd4512

vim-patch:8.1.1571: textprop highlight starts too early if just after a tab

Problem:    textprop highlight starts too early if just after a tab.
Solution:   Check if still drawing a previous character. (closes vim/vim#4558)
vim/vim@a956bf6

vim-patch:8.1.1573: textprop test fails if screenhots do not work

Problem:    Textprop test fails if screenhots do not work.
Solution:   Add check for screenhots working.
vim/vim@37e66cf

vim-patch:8.1.1928: popup windows don't move with the text when making changes

Problem:    Popup windows don't move with the text when making changes.
Solution:   Add the 'textprop" property to the popup window options, position
            the popup relative to a text property. (closes vim/vim#4560)
            No tests yet.
vim/vim@12034e2

vim-patch:8.1.1986: more functions can be used as methods

Problem:    More functions can be used as methods.
Solution:   Make textprop functions usable as a method.
vim/vim@a5a7882

vim-patch:8.1.2213: popup_textprop tests fail

Problem:    Popup_textprop tests fail.
Solution:   Adjust the column and line positioning.
vim/vim@aa1f04d

vim-patch:8.1.2307: positioning popup doesn't work for buffer-local textprop

Problem:    Positioning popup doesn't work for buffer-local textprop.
Solution:   Make it work. (closes vim/vim#5225)
vim/vim@a37cb55

vim-patch:8.1.2308: deleting text before zero-width textprop removes it

Problem:    Deleting text before zero-width textprop removes it.
Solution:   Keep zero-width textprop when deleting text.
vim/vim@ecafcc1

vim-patch:8.2.0126: textprop test fails

Problem:    Textprop test fails.
Solution:   Fix sign in computation.
vim/vim@94b6fb7

vim-patch:8.2.2470: popup_getoptions() does not get textprop from other tab

Problem:    Popup_getoptions() does not get textprop from other tab.
Solution:   use win_valid_any_tab(). (closes vim/vim#7786)
vim/vim@6502643

vim-patch:8.2.2471: popup_setoptions() does not set textprop in other tab

Problem:    Popup_setoptions() does not set textprop in other tab.
Solution:   use win_valid_any_tab(). (closes vim/vim#7788)
vim/vim@efa1923

vim-patch:8.2.2561: not all textprop code is covered by tests

Problem:    Not all textprop code is covered by tests.
Solution:   Add a few more test cases. (Dominique Pellé, closes vim/vim#7908)
vim/vim@3dc3474
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant