Avoid reallocating buffer for quickfix lines three times #831
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uickfix test case
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 12, 2016
Problem: The code to reallocate the buffer used for quickfix is repeated. Solution: Move the code to a function. (Yegappan Lakshmanan, closes vim/vim#831) vim/vim@2b2b8ae
24 tasks
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 13, 2016
Problem: The code to reallocate the buffer used for quickfix is repeated. Solution: Move the code to a function. (Yegappan Lakshmanan, closes vim/vim#831) vim/vim@2b2b8ae
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 13, 2016
Problem: The code to reallocate the buffer used for quickfix is repeated. Solution: Move the code to a function. (Yegappan Lakshmanan, closes vim/vim#831) vim/vim@2b2b8ae
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 14, 2016
Problem: The code to reallocate the buffer used for quickfix is repeated. Solution: Move the code to a function. (Yegappan Lakshmanan, closes vim/vim#831) vim/vim@2b2b8ae
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 14, 2016
Problem: The code to reallocate the buffer used for quickfix is repeated. Solution: Move the code to a function. (Yegappan Lakshmanan, closes vim/vim#831) vim/vim@2b2b8ae
jamessan
added a commit
to jamessan/neovim
that referenced
this pull request
Dec 27, 2016
Problem: The code to reallocate the buffer used for quickfix is repeated. Solution: Move the code to a function. (Yegappan Lakshmanan, closes vim/vim#831) vim/vim@2b2b8ae
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the quickfix code so that the memory allocation code for
increasing the line buffer size is not repeated three times.
Also, add an additional quickfix test case.