Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@chrisbra
Copy link
Member

@chrisbra chrisbra commented Sep 1, 2016

According to coveralls, normal.c is missing some tests. I am creating a PR here, to see, how coverage/travis/appveyor works.
That should increase coverage for normal.c and probably for a lot of other files as well. Let's see how this works.

The following tests have been added:

  • 'keymodel'
  • selectmode
  • OP_JOIN
  • OP_FILTER
  • op_formatexpr
  • op_colon
  • Foldopen, Folddelete
  • g@
  • unshift_special
  • clear_showcmd
  • del_from_showcmd
  • display_showcmd (should be covered by clear_showcmd)
  • nv_ignore
  • nv_error
  • nv_help
  • nv_page
  • nv_exmode
  • nv_hat
  • nv_Zet
  • several g cmds (g*, g#, ...)
  • all z cmds (z+, zt, ...)
  • K
  • tag commands (<c-]>, g], etc)
  • do_nv_ident
  • get_visual_text
  • [p [P ]P ]p
  • [' []' ]
  • nv_brace
  • nv_findpar
  • u guu
  • v_swap_corners
  • n_swapchar
  • nv_home
  • cw cW
  • nv_select
  • nv_normal
  • textobject iw/aw a[ a< as
  • nv_halfpage
  • nv_drop

and those lines should be covered:

  • 5553-5664
  • 5711-5722
  • 6235-6238
  • 6992-7000
  • 7049-7085
  • 7368-7374

NOT DONE:
Not sure how to test (mostly, because this is GUI stuff)

  • do_mouse
  • find_start_of_word
  • find_end_of_word
  • find_is_eval_item
  • nv_nop
  • lines 5176-5284

According to coveralls, normal.c is missing some tests.
The following needs tests:
- 'keymodel'
- selectmode
- OP_JOIN
- OP_FILTER
- op_formatexpr
- op_colon
- Foldopen, Folddelete
- g@
- unshift_special
- clear_showcmd
- del_from_showcmd
- display_showcmd (should be covered by clear_showcmd)
- nv_ignore
- nv_error
- nv_help
- nv_page
- nv_exmode
- nv_hat
- nv_Zet
- several g cmds (g*, g#, ...)
- all z cmds (z+, zt, ...)
- K
- tag commands (<c-]>, g], etc)
- do_nv_ident
- get_visual_text
- [p [P ]P ]p
- [' [` ]' ]`
- nv_brace
- nv_findpar
- <visual>u guu
- v_swap_corners
- n_swapchar
- nv_home
- cw cW
- nv_select
- nv_normal
- textobject iw/aw  a[ a< as
- nv_halfpage
- nv_drop

and those lines should be covered:
- 5553-5664
- 5711-5722
- 6235-6238
- 6992-7000
- 7049-7085
- 7368-7374

NOT DONE:
Not sure how to test (mostly, because this is GUI stuff)
- do_mouse
- find_start_of_word
- find_end_of_word
- find_is_eval_item
- nv_nop
- lines 5176-5284
@chrisbra chrisbra force-pushed the test_normal_squashed branch from 9e52014 to 8386c3b Compare September 1, 2016 20:19
@vim-ml
Copy link

vim-ml commented Sep 1, 2016

On Do, 01 Sep 2016, Christian Brabandt wrote:

According to coveralls, normal.c is missing some tests. I am creating a PR here, to see, how coverage/travis/appveyor works.
That should increase coverage for normal.c and probably for a lot of other files as well. Let's see how this works.
[...]
If I saw that correctly, coverage increase by over 1%. Unfortunately, it
failed in a simple test, so I force-pushed a small fix to that branch.
Build is still running, but I think it is a very good improvements.

Best,

Christian

Religion ist die Metaphysik des Volkes.
-- Arthur Schopenhauer

@chrisbra
Copy link
Member Author

chrisbra commented Sep 2, 2016

Failure on appveyor is unrelated to this change:

E660: Cannot open NetBeans connection info file: No such file or directory

@brammool
Copy link
Contributor

brammool commented Sep 2, 2016

Christian Brabandt wrote:

On Do, 01 Sep 2016, Christian Brabandt wrote:

According to coveralls, normal.c is missing some tests. I am creating a PR here, to see, how coverage/travis/appveyor works.
That should increase coverage for normal.c and probably for a lot of other files as well. Let's see how this works.
[...]
If I saw that correctly, coverage increase by over 1%. Unfortunately, it
failed in a simple test, so I force-pushed a small fix to that branch.
Build is still running, but I think it is a very good improvements.

That's a very big jump in coverage!

Is it ready to be included now?

I wish there was a knob on the TV to turn up the intelligence.
There's a knob called "brightness", but it doesn't seem to work.

/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \
\ an exciting new programming language -- http://www.Zimbu.org ///
\ help me help AIDS victims -- http://ICCF-Holland.org ///

@chrisbra
Copy link
Member Author

chrisbra commented Sep 2, 2016

Yes, I think it is ready

@brammool brammool closed this in 87bc3f7 Sep 3, 2016
@chrisbra chrisbra deleted the test_normal_squashed branch September 4, 2016 19:38
chrisbra pushed a commit to chrisbra/vim that referenced this pull request Sep 29, 2016
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim#1029)
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 11, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 12, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 12, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 13, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 15, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 15, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 15, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 16, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 16, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 17, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 18, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 18, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 19, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
raichoo added a commit to raichoo/neovim that referenced this pull request Mar 19, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim/vim#1029)

vim/vim@87bc3f7
desvp pushed a commit to desvp/vim that referenced this pull request May 30, 2017
Problem:    Insufficient testing for Normal mode commands.
Solution:   Add a big test. (Christian Brabandt, closes vim#1029)
guns added a commit to guns/vim that referenced this pull request Nov 22, 2017
* origin/master: (123 commits)
  patch 7.4.2330 Problem:    Coverity complains about not checking curwin to be NULL. Solution:   Use firstwin to avoid the warning.
  patch 7.4.2329 Problem:    Error for min() and max() contains %s. (Nikolay Pavlov) Solution:   Pass the function name. (closes vim#1040)
  patch 7.4.2328 Problem:    Crash when BufWinLeave autocmd goes to another tab page. (Hirohito             Higashi) Solution:   Make close_buffer() go back to the right window.
  patch 7.4.2327 Problem:    Freeing a variable that is on the stack. Solution:   Don't free res_tv or err_tv. (Ozaki Kiichi)
  patch 7.4.2326 Problem:    Illegal memory access when Visual selection starts in invalid             position. (Dominique Pelle) Solution:   Correct position when needed.
  patch 7.4.2325 Problem:    Tiny build fails. Solution:   Add #ifdef.
  patch 7.4.2324 Problem:    Crash when editing a new buffer and BufUnload autocommand wipes             out the new buffer. (Norio Takagi) Solution:   Don't allow wiping out this buffer. (partly by Hirohito Higashi)             Move old style test13 into test_autocmd. Avoid ml_get error when             editing a file.
  patch 7.4.2323 Problem:    Using freed memory when using 'formatexpr'. (Dominique Pelle) Solution:   Make a copy of 'formatexpr' before evaluating it.
  patch 7.4.2322 Problem:    Access memory beyond the end of the line. (Dominique Pelle) Solution:   Adjust the cursor column.
  patch 7.4.2321 Problem:    When a test is commented out we forget about it. Solution:   Let a test throw an exception with "Skipped" and list skipped test             functions. (Christian Brabandt)
  patch 7.4.2320 Problem:    Redraw problem when using 'incsearch'. Solution:   Save the current view when deleting characters. (Christian             Brabandt) Fix that the '" mark is set in the wrong position. Don't             change the search start when using BS.
  patch 7.4.2319 Problem:    No way for a system wide vimrc to stop loading defaults.vim.             (Christian Hesse) Solution:   Bail out of defaults.vim if skip_defaults_vim was set.
  patch 7.4.2318 Problem:    When 'incsearch' is not set CTRL-T and CTRL-G are not inserted as             before. Solution:   Move #ifdef and don't use goto.
  patch 7.4.2317 Problem:    Normal mode tests fail on MS-Windows. Solution:   Do some tests only on Unix.  Set 'fileformat' to "unix".
  patch 7.4.2316 Problem:    Channel sort test is flaky. Solution:   Add a check the output has been read.
  patch 7.4.2315 Problem:    Insufficient testing for Normal mode commands. Solution:   Add a big test. (Christian Brabandt, closes vim#1029)
  patch 7.4.2314 Problem:    No error when deleting an augroup while it's the current one. Solution:   Disallow deleting an augroup when it's the current one.
  patch 7.4.2313 Problem:    Crash when deleting an augroup and listing an autocommand.             (Dominique Pelle) Solution:   Make sure deleted_augroup is valid.
  patch 7.4.2312 Problem:    Crash when autocommand moves to another tab. (Dominique Pelle) Solution:   When navigating to another window halfway the :edit command go             back to the right window.
  patch 7.4.2311 Problem:    Appveyor 64 bit build still using Python 3.4 Solution:   Switch to Python 3.5. (Ken Takata, closes vim#1032)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants