Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@yousong
Copy link

@yousong yousong commented Sep 19, 2016

Problem:    Wrong header and library files from system directory may be
            used instead of the ones specified on configure command line
Solution:   Compile with XXX_FLAGS appearing before ALL_CFLAGS

I came across the issue firstly with lua support when I try to have my own build of vim and its dependencies (https://github.com/yousong/build-scripts/blob/master/build-vim.sh).

@nuko8
Copy link

nuko8 commented Sep 19, 2016

Just to make sure. Does $(call variable, param, param,…) work with make(1) other than GNU make?

@yousong
Copy link
Author

yousong commented Sep 19, 2016

Other choices would be

  1. Prepending those LUA_CFLAGS, PERL_CFLAGS, etc. to ALL_CFLAGS
  2. Expand manually the $(call CCC,xxx) to eliminate possible compatibility issues altoghter

Personally I prefer the first choice, but it may also happen that different XXX_CFLAGS interfere with each other...

Problem:    Wrong header and library files from system directory may be
            used instead of the ones specified on configure command line
Solution:   Compile with XXX_FLAGS appearing before ALL_CFLAGS
@yousong
Copy link
Author

yousong commented Sep 19, 2016

Changes v1 -> v2

  • Avoid using $(call CCC,xxx)
  • Expand the change to include targets missed out in previous version

@yousong
Copy link
Author

yousong commented Dec 10, 2016

Hi, @brammool , 3 monthes have passed, any thoughts on this one?

@brammool brammool closed this in 6e78e27 Jan 17, 2017
desvp pushed a commit to desvp/vim that referenced this pull request May 30, 2017
Problem:    Order of complication flags is sometimes wrong.
Solution:   Put interface-specific flags before ALL_CFLAGS. (idea by Yousong
            Zhou, closes vim#1100)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants