an action help language CTRL-] in tag.c fixed #1249
Conversation
|
Hi Tatsuki, 2016-11-12(Sat) 16:49:47 UTC+9 Tatsuki:
Nice patch!
I wrote a patch to add a test for this. (Attached) BTW, I found a bit wrong indentation. TAB SPC SPC SPC SPC TAB SPC SPC SPC SPC TAB TAB SPC SPC SPC SPCBest regards, |
src/tag.c
Outdated
| #ifdef FEAT_MULTI_LANG | ||
| /* Set a flag if the file extension is .txt */ | ||
| int is_txt = 0; | ||
| if ((flags & TAG_KEEP_LANG) |
src/tag.c
Outdated
| */ | ||
| #ifdef FEAT_MULTI_LANG | ||
| /* Set a flag if the file extension is .txt */ | ||
| int is_txt = 0; |
There was a problem hiding this comment.
there is a statment before this declaration. vim doesn't support C99. so move up this declaration with #ifdef FEAT_MULTI_LANG.
There was a problem hiding this comment.
I moved the definition to 1359.
|
The declaration |
| char_u *help_lang_find = NULL; /* lang to be found */ | ||
| char_u help_lang[3]; /* lang of current tags file */ | ||
| char_u *saved_pat = NULL; /* copy of pat[] */ | ||
| int is_txt = FALSE; /* flag of file extension */ |
There was a problem hiding this comment.
You need to enclose this in #ifdef FEAT_MULTI_LANG ～ #endif
There was a problem hiding this comment.
Ah, It was already surrounded. sorry.
There was a problem hiding this comment.
It is not necessary that you apologize
Thank you for teaching me.
|
this test was created by h_east. |
|
@Tatsuki-I thanks. looks good to me. |
Problem: When reading English help and using CTRl-] the language from
'helplang' is used.
Solution: Make help tag jumps keep the language. (Tatsuki, test by Hirohito
Higashi, closes vim/vim#1249)
vim/vim@6dbf66a
Problem: When reading English help and using CTRl-] the language from
'helplang' is used.
Solution: Make help tag jumps keep the language. (Tatsuki, test by Hirohito
Higashi, closes vim#1249)
When I set translated help(for example:
set helplang=ja,enin .vimrc), open translated help and pressCTRL-], Vim opens help in translated help, but open English help and pressCTRL-], Vim opens translated help.I'd like vim to open same language help as current opened help.
So, I fixed tag.c.