Fix for #1255: add STATIC_WINPTHREAD to allow static winpthread. #1256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How about following the setting of ifndef STATIC_WINPTHREAD
STATIC_WINPTHREAD=$(STATIC_STDCPLUS)
endif |
|
That makes sense to me. Will make the change. Fewer options to pass in most cases probably. Thanks for looking it over! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential fix for #1255. It adds a STATIC_WINPTHREAD build variable which when set to 'yes' will allow linking the winpthread library statically.
To maintain existing build by default, I'm initializing the value to 'no' if not set. I'm not certain though whether this is a widespread problem. If it is, perhaps the default should be 'yes'.
I'd welcome any ideas or suggestions on how to test more widely outside of my system.