Convert vim_memcmp calls to directly using memcmp #1295
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vim_memcmp exists to abstract how the memory comparison is performed on various systems and to fallback to Vim's own memcmp implementation, if needed. However, there have been various direct memcmp calls in Vim since at least 2010 without issue. Converting the remaining vim_memcmp calls to memcmp allows us to remove the reimplementation of memcmp and reduces the need to know another Vim-specific function that should be used.
|
James McCoy wrote:
vim_memcmp exists to abstract how the memory comparison is performed on
various systems and to fallback to Vim's own memcmp implementation, if
needed. However, there have been various direct memcmp calls in Vim
since at least 2010 without issue.
Converting the remaining vim_memcmp calls to memcmp allows us to remove
the reimplementation of memcmp and reduces the need to know another
Vim-specific function that should be used.
Thanks. Those calls to memcmp() are protected by a feature flag, but I
suppose it's widespread enough to be OK now.
…--
hundred-and-one symptoms of being an internet addict:
66. You create a homepage with the impression to cure the afflicted...but
your hidden agenda is to receive more e-mail.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Still checking if memcmp() exists while every system should have
it now.
Solution: Remove vim_memcmp(). (James McCoy, closes vim#1295)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vim_memcmp exists to abstract how the memory comparison is performed on
various systems and to fallback to Vim's own memcmp implementation, if
needed. However, there have been various direct memcmp calls in Vim
since at least 2010 without issue.
Converting the remaining vim_memcmp calls to memcmp allows us to remove
the reimplementation of memcmp and reduces the need to know another
Vim-specific function that should be used.