__sun should be used instead of sun to detect Solaris/illumos to allo… #1296
Conversation
…w build with -std=c99
|
Since when is "__sun" defined? Perhaps we still need "sun" for older systems. |
|
It's defined by the compiler, so it depends on how old a compiler you think people are using. |
|
gcc 2.95 also defines __sun. See also the 'Solaris' section here: |
|
Tom Christensen wrote:
gcc 2.95 also defines __sun.
```
$ uname -srp
SunOS 5.6 sparc
$ /usr/tgcware/gcc29/bin/gcc -E -dM - < /dev/null | grep sun
#define __sun 1
#define __sun__ 1
#define sun 1
```
See also the 'Solaris' section here:
https://sourceforge.net/p/predef/wiki/OperatingSystems/
Perhaps we should do:
#if defined(sun) || defined(__sun)
# define SUN_SYSTEM
#endif
To catch them all? And then use SUN_SYSTEM where needed.
…--
hundred-and-one symptoms of being an internet addict:
80. At parties, you introduce your spouse as your "service provider."
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
|
Do you have any evidence of people using twenty-plus-year-old compilers to compile vim on Solaris (well, SunOS at that point, I guess)? If not, I think just using __sun should be fine. If so, then perhaps and then you get to use the modern macro. |
Problem: Modern Sun compilers define "__sun" instead of "sun". Solution: Use __sun. (closes vim#1296)
…w build with -std=c99