js_decode should handle single quote #1371
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that patch 8.0.0171 already includes the proposed patch, but it looks like JSON should only accept double quotes. See this link for example: https://discuss.newrelic.com/t/json-parser-doesnt-accept-single-quote-characters/860/5 Where do you see that single quotes should also be accepted? |
|
Dominique Pellé wrote:
I see that patch 8.0.0171 already includes the proposed patch, but it looks like JSON should only accept double quotes. See this link for example: https://discuss.newrelic.com/t/json-parser-doesnt-accept-single-quote-characters/860/5
Where do you see that single quotes should also be accepted?
This is for js_decode(), not json_decode(). The test verifies that
single quotes fail for json_decode().
…--
Vi is clearly superior to emacs, since "vi" has only two characters
(and two keystrokes), while "emacs" has five. (Randy C. Ford)
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: JS style JSON does not support single quotes. Solution: Allow for single quotes. (Yasuhiro Matsumoto, closes vim#1371)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should work.