vim_strcat: Allow overlap in both branches. #1415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memmove supports overlapped pointers, but strcpy does not.
|
Thanks. Was this breaking anything? |
|
On Jan 27, 2017 21:53, "Bram Moolenaar" ***@***.***> wrote:
Thanks. Was this breaking anything?
Not that I am aware of. I thought I would leave it up for debate :)
…---
Justin M. Keyes
|
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Mar 25, 2017
Problem: vim_strcat() cannot handle overlapping arguments.
Solution: Use mch_memmove() instead of strcpy(). (Justin M Keyes,
closes vim#1415)
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: vim_strcat() cannot handle overlapping arguments.
Solution: Use mch_memmove() instead of strcpy(). (Justin M Keyes,
closes vim#1415)
justinmk
pushed a commit
to neovim/neovim
that referenced
this pull request
Nov 12, 2017
* vim-patch:8.0.0245 Problem: The generated zh_CN.cp936.po message file is not encoded properly. Solution: Instead of using zh_CN.po as input, use zh_CN.UTF-8.po. vim/vim@16038d5 * vim-patch:8.0.0248 Problem: vim_strcat() cannot handle overlapping arguments. Solution: Use mch_memmove() instead of strcpy(). (Justin M Keyes, closes vim/vim#1415) vim/vim@45600ce
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "true" case in
vim_strcatusesmch_memmovewhich supports overlapped pointers, but the "false" case usesstrcpy, which does not. Usemch_memmovein both cases.