Fixed invalid memory access with :set complete=s\ #1478
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dominique wrote:
This PR fixes an invalid memory access in Vim-8.0.329 and older when
the 'complete' option is set with a single trailing backslash:
```
:set complete=s\
```
Valgrind error:
```
==23076== Invalid read of size 1
==23076== at 0x4F54AB: did_set_string_option.constprop.10 (option.c:7018)
==23076== by 0x4FAD30: do_set (option.c:5006)
==23076== by 0x46B734: do_one_cmd (ex_docmd.c:2981)
==23076== by 0x46B734: do_cmdline (ex_docmd.c:1120)
==23076== by 0x4D71E4: nv_colon (normal.c:5403)
==23076== by 0x4E0EF1: normal_cmd (normal.c:1150)
==23076== by 0x5BED24: main_loop (main.c:1315)
==23076== by 0x5BFDF2: vim_main2 (main.c:877)
==23076== by 0x40C3D3: main (main.c:415)
==23076== Address 0x9854eb3 is 0 bytes after a block of size 3 alloc'd
==23076== at 0x4C2ABF5: malloc (vg_replace_malloc.c:299)
==23076== by 0x4C4D0B: lalloc (misc2.c:942)
==23076== by 0x4FA72A: do_set (option.c:4796)
==23076== by 0x46B734: do_one_cmd (ex_docmd.c:2981)
==23076== by 0x46B734: do_cmdline (ex_docmd.c:1120)
==23076== by 0x4D71E4: nv_colon (normal.c:5403)
==23076== by 0x4E0EF1: normal_cmd (normal.c:1150)
==23076== by 0x5BED24: main_loop (main.c:1315)
==23076== by 0x5BFDF2: vim_main2 (main.c:877)
==23076== by 0x40C3D3: main (main.c:415)
```
Bug was found using afl-fuzz.
Thanks. We do need to make sure that the keys are executed:
call feedkeys("i\<C-N>")
Should be:
call feedkeys("i\<C-N>", 'xt')
…--
BEDEVERE: And what do you burn, apart from witches?
FOURTH VILLAGER: ... Wood?
BEDEVERE: So why do witches burn?
SECOND VILLAGER: (pianissimo) ... Because they're made of wood...?
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Mar 25, 2017
…lash Problem: Illegal memory access when 'complete' ends in a backslash. Solution: Check for trailing backslash. (Dominique Pelle, closes vim#1478)
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
…lash Problem: Illegal memory access when 'complete' ends in a backslash. Solution: Check for trailing backslash. (Dominique Pelle, closes vim#1478)
nateozem
pushed a commit
to nateozem/neovim
that referenced
this pull request
Oct 5, 2017
Problem: Illegal memory access when 'complete' ends in a backslash. Solution: Check for trailing backslash. (Dominique Pelle, closes vim/vim#1478) vim/vim@226c534
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an invalid memory access in Vim-8.0.329 and older when
the 'complete' option is set with a single trailing backslash:
Valgrind error:
Bug was found using afl-fuzz.