Fix handling of all 2-/3-character :sub variants #1479
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
James McCoy wrote:
As can be seen at ":help :sgr", there's an entire table describing
2-/3-character variations on the :substitute command, which embed flags
in the command name. However, all of those commands actually fail with
"E488: Trailing characters".
This PR adds explicit handling for the named commands and some minimal
testing that they work.
You have misunderstood how this works. When putting flags right after
":s" no pattern or substitute string can follow. E.g.:
:sIe/foo/bar/
Should be written as:
:s/foo/bar/Ie
Or you can first do:
:s/foo/bar/
And then:
:sIe
The tests are still useful, I'll include those. And make it test both
:s/from/to/{flags} and :s{flags}
…--
BEDEVERE: And that, my lord, is how we know the Earth to be banana-shaped.
"Monty Python and the Holy Grail" PYTHON (MONTY) PICTURES LTD
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
Ok. That isn't very clear from the documentation. |
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Mar 25, 2017
Problem: Flags of :substitute not sufficiently tested. Solution: Test up to two letter flag combinations. (James McCoy, closes vim#1479)
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Flags of :substitute not sufficiently tested. Solution: Test up to two letter flag combinations. (James McCoy, closes vim#1479)
justinmk
added a commit
to justinmk/neovim
that referenced
this pull request
Jan 1, 2018
Problem: Flags of :substitute not sufficiently tested. Solution: Test up to two letter flag combinations. (James McCoy, closes vim/vim#1479) vim/vim@8c50d50
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As can be seen at ":help :sgr", there's an entire table describing
2-/3-character variations on the :substitute command, which embed flags
in the command name. However, all of those commands actually fail with
"E488: Trailing characters".
This PR adds explicit handling for the named commands and some minimal
testing that they work.