Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fixed invalid memory access with 'cinkeys' #1492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fixed invalid memory access with 'cinkeys' #1492

wants to merge 2 commits into from

Conversation

@dpelle
Copy link
Member

@dpelle dpelle commented Feb 19, 2017

This PR fixes an invalid memory access in vim-8.0.341 and older.
It's an old bug since it was in vim-7.4.52 already.
I did not check earlier version.
Bug was found using afl-fuzz.

Step to reproduce:

$ vim -u NONE -c'set cin cinkeys=0' -c 'norm a' -cq 2>log

And log file contains:

==4184== Memcheck, a memory error detector
==4184== Copyright (C) 2002-2015, and GNU GPL'd, by Julian Seward et al.
==4184== Using Valgrind-3.12.0.SVN and LibVEX; rerun with -h for copyright info
==4184== Command: ./vim -u NONE -cset\ cin\ cinkeys=0 -c norm\ a -cq
==4184== 
==4184== Invalid read of size 1
==4184==    at 0x4B5C84: skip_to_option_part (misc1.c:2707)
==4184==    by 0x41D5DC: in_cinkeys (edit.c:8187)
==4184==    by 0x41AB1A: edit (edit.c:949)
==4184==    by 0x4DCB1D: nv_edit (normal.c:0)
==4184==    by 0x4D5E63: normal_cmd (normal.c:1150)
==4184==    by 0x461DF1: exec_normal (ex_docmd.c:10418)
==4184==    by 0x461CE8: exec_normal_cmd (ex_docmd.c:10401)
==4184==    by 0x461CE8: ex_normal (ex_docmd.c:10310)
==4184==    by 0x45CD1D: do_one_cmd (ex_docmd.c:2981)
==4184==    by 0x458F7D: do_cmdline (ex_docmd.c:1120)
==4184==    by 0x5D1E4C: exe_commands (main.c:2905)
==4184==    by 0x5D1E4C: vim_main2 (main.c:781)
==4184==    by 0x5D0779: main (main.c:415)
==4184==  Address 0x7690d32 is 0 bytes after a block of size 2 alloc'd
==4184==    at 0x4C2ABF5: malloc (vg_replace_malloc.c:299)
==4184==    by 0x4C5A37: lalloc (misc2.c:942)
==4184==    by 0x4F2306: do_set (option.c:4799)
==4184==    by 0x45CD1D: do_one_cmd (ex_docmd.c:2981)
==4184==    by 0x458F7D: do_cmdline (ex_docmd.c:1120)
==4184==    by 0x5D1E4C: exe_commands (main.c:2905)
==4184==    by 0x5D1E4C: vim_main2 (main.c:781)
==4184==    by 0x5D0779: main (main.c:415)
(snip more errors)

@brammool brammool closed this in 60629d6 Feb 23, 2017
chrisbra pushed a commit to chrisbra/vim that referenced this pull request Mar 25, 2017
@brammool @chrisbra
patch 8.0.0358: invalid memory access in C-indent code
87ad1ec 
Problem:    Invalid memory access in C-indent code.
Solution:   Don't go over end of empty line. (Dominique Pelle, closes vim#1492)
desvp pushed a commit to desvp/vim that referenced this pull request May 30, 2017
@brammool @desvp
patch 8.0.0358: invalid memory access in C-indent code
05acbe0 
Problem:    Invalid memory access in C-indent code.
Solution:   Don't go over end of empty line. (Dominique Pelle, closes vim#1492)
@ckelsel ckelsel mentioned this pull request Jan 9, 2018
Merged
justinmk pushed a commit to neovim/neovim that referenced this pull request Jan 30, 2018
@ckelsel @justinmk
vim-patch:8.0.0358,8.0.0359 (#7832)
649123d 
vim-patch:8.0.0358: invalid memory access in C-indent code
Problem:    Invalid memory access in C-indent code.
Solution:   Don't go over end of empty line. (Dominique Pelle, closes vim/vim#1492)
vim/vim@60629d6

vim-patch:8.0.0359: 'number' and 'relativenumber' are not properly tested
Problem:    'number' and 'relativenumber' are not properly tested.
Solution:   Add tests, change old style to new style tests. (Ozaki Kiichi,
            closes vim/vim#1447)
vim/vim@dc9a081
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dpelle