Ensure v:progpath is set to an absolute path #1531
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ed150a6 to
3da23f6
Compare
mch_can_exe will already walk $PATH, if needed, to find the executable. Since it knows enough information to set v:progpath to an absolute path (via SearchPath on Windows and FullName_save on Linux), let it do so. This removes any ambiguity about what v:progpath refers to.
FullName_save was only being called for paths like "./src/vim" but "src/vim" should also be expanded to an absolute path.
3da23f6 to
48211ab
Compare
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Mar 25, 2017
Problem: Setting v:progpath is not quite right.
Solution: On MS-Windows add the extension. On Unix use the full path for a
relative directory. (partly by James McCoy, closes vim#1531)
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Setting v:progpath is not quite right.
Solution: On MS-Windows add the extension. On Unix use the full path for a
relative directory. (partly by James McCoy, closes vim#1531)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just uses the existing logic in mch_can_exe to populate a buffer with the
absolute path to the binary. The Windows code was already walking
$PATH, so it seems pointless not to actually use the information.
There's no reason not to behave the same way on non-Windows platforms,
so change the code to always use mch_can_exe. With a small fix to how
mch_can_exe determines whether FullName_save is needed.