Improved test coverage of folds #1579
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Dominique Pellé wrote:
This PR improves test coverage of the fold feature.
Thanks!
While writing the tests, I found something unclear
about the behavior of the ":folddoclosed" command
with a range.
If I run:
```
$ vim -u NONE \
-c 'call setline(1, range(1, 6))' \
-c '3,5 fold' \
-c '2,4 folddoclosed s/$/ CLOSED/'
```
What should line 5 contain?
It currently contains "5 CLOSED" despite giving
the range 2,4 to the folddoclosed command.
Reading the ":help folddoclosed", I would have
expected line 5 to contain "5" instead of "5 CLOSED".
Is this a bug? If not, the doc is unclear.
It looks like folddoclosed with a range applies
the command to all lines in closed folds that
overlap with the range, and not all lines in the
range.
Since I don't know the expected behavior, for now I
did not test folddoclosed with a closed fold that partially
overlaps the range.
The line ranges are adjusted to the start and end of a fold. Normally
that is good, since you can't see what is inside the fold, thus the
range is rounded up. If you don't want that you should open the fold
first.
However, for :folddoclosed this doesn't work well, since opening the
fold completely defeats its purpose. Yet, why would someone stop
halfway a fold?
On the other hand, consistency matters. Near the end of fold.txt the
behavior even says "always":
For Ex commands that work on buffer lines the range is adjusted
to always start at the first line of a closed fold and end at
the last line of a closed fold.
…--
hundred-and-one symptoms of being an internet addict:
175. You send yourself e-mail before you go to bed to remind you
what to do when you wake up.
/// Bram Moolenaar -- [email protected] -- http://www.Moolenaar.net \\\
/// sponsor Vim, vote for features -- http://www.Vim.org/sponsor/ \\\
\\\ an exciting new programming language -- http://www.Zimbu.org ///
\\\ help me help AIDS victims -- http://ICCF-Holland.org ///
|
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Mar 25, 2017
Problem: Insufficient testing for folding. Solution: Add a couple more fold tests. (Dominique Pelle, closes vim#1579)
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Mar 28, 2017
Problem: Insufficient testing for folding. Solution: Add a couple more fold tests. (Dominique Pelle, closes vim#1579)
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Insufficient testing for folding. Solution: Add a couple more fold tests. (Dominique Pelle, closes vim#1579)
justinmk
pushed a commit
to neovim/neovim
that referenced
this pull request
May 26, 2018
Problem: Insufficient testing for folding. Solution: Add a couple more fold tests. (Dominique Pelle, closes vim/vim#1579) vim/vim@518c9b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves test coverage of the fold feature.
While writing the tests, I found something unclear
about the behavior of the ":folddoclosed" command
with a range.
If I run:
What should line 5 contain?
It currently contains "5 CLOSED" despite giving
the range 2,4 to the folddoclosed command.
Reading the ":help folddoclosed", I would have
expected line 5 to contain "5" instead of "5 CLOSED".
Is this a bug? If not, the doc is unclear.
It looks like folddoclosed with a range applies
the command to all lines in closed folds that
overlap with the range, and not all lines in the
range.
Since I don't know the expected behavior, for now I
did not test folddoclosed with a closed fold that partially
overlaps the range.