allow get/set tab-local 'cmdheight' via gettabvar()/settabvar() #15713
Conversation
|
|
||
| /* | ||
| * "indir" values for tab-local options. | ||
| * These need to be defined globally, so that the TV_COUNT can be used in the |
There was a problem hiding this comment.
Yes. Fix the comment or remove the definition?
There was a problem hiding this comment.
Actually I think that means the implementation is incomplete. BV_COUNT and WV_COUNT are used for arrays that store script contexts that set local options, so if 'cmdheight' needs to be a fully tab-local option it's necessary to store a script context with the tabpage as well.
There was a problem hiding this comment.
I think that should be done in a separate PR about cmdheight.
Because there is only one tab-local option.
There was a problem hiding this comment.
Yeah, but we should still remember when this option was (re-)set right?
There was a problem hiding this comment.
I'll write another PR to make cmdheight as a true tab-local option.
And in the meantime I'd like to mark this PR as a WIP.
Fixes #4324.
Related #13893.