Replace (*mb_char2len)(c) with utf_char2len(c) where possible #1582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Using a function pointer instead of the actual function, which we
know.
Solution: Change mb_ functions to utf_ functions when already checked for
Unicode. (Dominique Pelle, closes vim#1582)
justinmk
pushed a commit
to neovim/neovim
that referenced
this pull request
Jun 10, 2018
…own (#8513) Problem: Using a function pointer instead of the actual function, which we know. Solution: Change mb_ functions to utf_ functions when already checked for Unicode. (Dominique Pelle, closes vim/vim#1582) vim/vim@ace9598
ZviRackover
added a commit
to ZviRackover/neovim
that referenced
this pull request
Jun 29, 2018
Problem: Using a function pointer instead of the actual function, which we
know.
Solution: Change mb_ functions to utf_ functions when already checked for
Unicode. (Dominique Pelle, closes vim/vim#1582)
vim/vim@ace9598
In addition to merging the above patch, entirely removed the mb_ptr2char macro
and its uses.
ZviRackover
added a commit
to ZviRackover/neovim
that referenced
this pull request
Jun 29, 2018
… is known
Problem: Using a function pointer instead of the actual function, which we
know.
Solution: Change mb_ functions to utf_ functions when already checked for
Unicode. (Dominique Pelle, closes vim/vim#1582)
vim/vim@ace9598
In addition to merging the above patch, entirely removed the mb_ptr2char macro
and its uses.
ZviRackover
added a commit
to ZviRackover/neovim
that referenced
this pull request
Jun 29, 2018
… is known
Problem: Using a function pointer instead of the actual function, which we
know.
Solution: Change mb_ functions to utf_ functions when already checked for
Unicode. (Dominique Pelle, closes vim/vim#1582)
vim/vim@ace9598
In addition to merging the above patch, entirely removed the mb_ptr2char macro
and its uses. The same can be done for all deprecated mb_ functions in follow-up
patches.
ZviRackover
added a commit
to ZviRackover/neovim
that referenced
this pull request
Jun 30, 2018
… is known
Problem: Using a function pointer instead of the actual function, which we
know.
Solution: Change mb_ functions to utf_ functions when already checked for
Unicode. (Dominique Pelle, closes vim/vim#1582)
vim/vim@ace9598
In addition to merging the above patch, entirely removed the mb_ptr2char macro
and its uses. The same can be done for all deprecated mb_ functions in follow-up
patches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes calls like (*mb_char2len)(c) into utf_char2len(c) wherever
we know that enc_utf8 is true. That's already done in Vim source code in
several places, but not systematically.
It should be a bit faster in theory. Admittedly, I did not see any measurable
difference in speed, so I hesitated to push this this change. But since I didn't
see any drawback, I created the PR. Perhaps it makes more difference
in speed when building vim with -fwhole-program as calling (*mb_char2len)(c)
with a function pointer should prevent interprocedural optimizations unlike
calling utf_char2len(c) directly.