Clean-up make_cmdidxs.pl #1594
Closed
Clean-up make_cmdidxs.pl #1594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1594 +/- ##
==========================================
- Coverage 74.55% 74.55% -0.01%
==========================================
Files 76 76
Lines 124841 124842 +1
==========================================
Hits 93070 93070
- Misses 31771 31772 +1
Continue to review full report at Codecov.
|
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Mar 28, 2017
Problem: Script for creating cmdidxs can be improved.
Solution: Count skipped lines instead of collecting the lines. Add "const".
(Dominique Pelle, closes vim#1594)
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Script for creating cmdidxs can be improved.
Solution: Count skipped lines instead of collecting the lines. Add "const".
(Dominique Pelle, closes vim#1594)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a minor cleanup in script create_cmdidxs.pl:
whereas we only need to count skipped commands.
which is not needed if we compute value differently.