Fix ins-completion that was slowed down by 8.0.0050 #1591
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1591 +/- ##
==========================================
- Coverage 74.53% 74.53% -0.01%
==========================================
Files 76 76
Lines 124800 124800
==========================================
- Hits 93023 93022 -1
- Misses 31777 31778 +1
Continue to review full report at Codecov.
|
chrisbra
pushed a commit
to chrisbra/vim
that referenced
this pull request
Mar 28, 2017
Problem: Check for available characters takes too long.
Solution: Only check did_start_blocking if wtime is negative. (Daisuke
Suzuki, closes vim#1591)
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Check for available characters takes too long.
Solution: Only check did_start_blocking if wtime is negative. (Daisuke
Suzuki, closes vim#1591)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 8.0.0050, an extra waiting occurs when reading completion candidates from other files in ins-completion.
Example(compl-dictionary)
Therefore, fixed the conditional statement so that the waiting does not occur.
This patch was advised by @h-east .
Ref: vim-jp/issues#1040