Do not highlight the first matched entry in wildmenu #1602
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we just want to show the matching items (eg: wim=longest:full,full and the user presses <tab> for the first time) there's no need to highlight the first item.
Codecov Report
@@ Coverage Diff @@
## master #1602 +/- ##
==========================================
+ Coverage 74.58% 74.62% +0.04%
==========================================
Files 76 76
Lines 124776 124816 +40
==========================================
+ Hits 93067 93149 +82
+ Misses 31709 31667 -42
Continue to review full report at Codecov.
|
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: When 'wildmenu' is set and 'wildmode' has "longest" then the first
file name is highlighted, even though the text shows the longest
match.
Solution: Do not highlight the first match. (LemonBoy, closes vim#1602)
doubleloop
pushed a commit
to doubleloop/neovim
that referenced
this pull request
Jan 28, 2018
Problem: When 'wildmenu' is set and 'wildmode' has "longest" then the first
file name is highlighted, even though the text shows the longest
match.
Solution: Do not highlight the first match. (LemonBoy, closes vim/vim#1602)
vim/vim@ef8eb08
doubleloop
pushed a commit
to doubleloop/neovim
that referenced
this pull request
Jan 28, 2018
Problem: When 'wildmenu' is set and 'wildmode' has "longest" then the first
file name is highlighted, even though the text shows the longest
match.
Solution: Do not highlight the first match. (LemonBoy, closes vim/vim#1602)
vim/vim@ef8eb08
doubleloop
pushed a commit
to doubleloop/neovim
that referenced
this pull request
Jan 28, 2018
Problem: When 'wildmenu' is set and 'wildmode' has "longest" then the first
file name is highlighted, even though the text shows the longest
match.
Solution: Do not highlight the first match. (LemonBoy, closes vim/vim#1602)
vim/vim@ef8eb08
mhinz
pushed a commit
to neovim/neovim
that referenced
this pull request
Jan 29, 2018
#7927) Problem: When 'wildmenu' is set and 'wildmode' has "longest" then the first file name is highlighted, even though the text shows the longest match. Solution: Do not highlight the first match. (LemonBoy, closes vim/vim#1602) vim/vim@ef8eb08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we just want to show the matching items (eg: wim=longest:full,full
and the user presses for the first time) there's no need to
highlight the first item.