Fix E303 errors if 'directory' isn't writable opening a cmdwin #1620
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1620 +/- ##
==========================================
+ Coverage 74.68% 74.68% +<.01%
==========================================
Files 76 76
Lines 124849 124888 +39
==========================================
+ Hits 93241 93274 +33
- Misses 31608 31614 +6
Continue to review full report at Codecov.
|
This avoids a spurious E303 message if 'directory' happens to not contain any writable paths when a cmdwin is opened.
23cd6cb to
639a4c2
Compare
desvp
pushed a commit
to desvp/vim
that referenced
this pull request
May 30, 2017
Problem: Swap file exists briefly when opening the command window.
Solution: Set the noswapfile command modifier before splitting the window.
(James McCoy, closes vim#1620)
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jun 18, 2018
… window
Problem: Swap file exists briefly when opening the command window.
Solution: Set the noswapfile command modifier before splitting the window.
(James McCoy, closes vim/vim#1620)
vim/vim@3bab939
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jun 19, 2018
… window
Problem: Swap file exists briefly when opening the command window.
Solution: Set the noswapfile command modifier before splitting the window.
(James McCoy, closes vim/vim#1620)
vim/vim@3bab939
justinmk
pushed a commit
to neovim/neovim
that referenced
this pull request
Jun 19, 2018
… window (#8588) Problem: Swap file exists briefly when opening the command window. Solution: Set the noswapfile command modifier before splitting the window. (James McCoy, closes vim/vim#1620) vim/vim@3bab939
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, opening a cmdwin creates the buffer and then sets a few
options on that buffer, including 'noswapfile'. That leaves a gap where
a swap file gets created, potentially showing a useless error to the user.
Since there's now the :noswapfile command modifier, let's check that to
set the buffer-local value of 'swapfile' when creating a new buffer.
That allows us to then set cmdmod.noswapfile when creating the buffer
for a cmdwin, to prevent the swapfile from ever being created.