Make :stag observe the 'switchbuf' option #1681
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The useopen and usetab values of 'switchbuf' should (according to :help 'swb') be _used in all buffer related split commands, for example ":sbuffer", ":sbnext", or ":sbrewind"._ The :stag / :stselect / :stjump commands also split windows and open a new buffer. Therefore, users expect them to be influenced by 'switchbuf' as well, but they currently are not. When navigating tags, :set switchbuf=useopen can have great benefits: It avoids that multiple buffers with the same source file are opened; users will end up with the minimum amount of split windows, just one for each source file, and do not have to manually manage duplicate window splits. The implementation in jumpto_tag() parallels the one in buflist_getfile(). getfile_result, already used later as a flag is now initialized at the beginning of the function, and used to actually skip the getfile() call if a window reuse has happened.
This tests the default (empty) 'switchbuf' behavior (new split window), "useopen" (second :stag reuses current file), "usetab" (second :stag reuses file in different tab page).
The debugger showed me that fname is a relative one (.\foo.c) on Windows; buflist_findname() expects a full one (ffname). Therefore, need to use buflist_findname_exp() to resolve fname into ffname. I'm not sure why this works on Linux without the conversion, though...
Codecov Report
@@ Coverage Diff @@
## master #1681 +/- ##
==========================================
+ Coverage 74.85% 74.91% +0.05%
==========================================
Files 76 76
Lines 124942 124954 +12
==========================================
+ Hits 93521 93604 +83
+ Misses 31421 31350 -71
Continue to review full report at Codecov.
|
dpelle
pushed a commit
to dpelle/vim
that referenced
this pull request
Jul 31, 2017
Problem: The ":stag" command does not respect 'switchbuf'.
Solution: Check 'switchbuf' for tag commands that may open a new window.
(Ingo Karkat, closes vim#1681) Define macros for the return values
of getfile().
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jun 21, 2018
Problem: The ":stag" command does not respect 'switchbuf'.
Solution: Check 'switchbuf' for tag commands that may open a new window.
(Ingo Karkat, closes vim/vim#1681) Define macros for the return values
of getfile().
vim/vim@8ad80de
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jun 21, 2018
Problem: The ":stag" command does not respect 'switchbuf'.
Solution: Check 'switchbuf' for tag commands that may open a new window.
(Ingo Karkat, closes vim/vim#1681) Define macros for the return values
of getfile().
vim/vim@8ad80de
janlazo
added a commit
to janlazo/neovim
that referenced
this pull request
Jun 21, 2018
Problem: The ":stag" command does not respect 'switchbuf'.
Solution: Check 'switchbuf' for tag commands that may open a new window.
(Ingo Karkat, closes vim/vim#1681) Define macros for the return values
of getfile().
vim/vim@8ad80de
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
useopenandusetabvalues of'switchbuf'should (according to:help 'swb') be used in all buffer related split commands, for example ":sbuffer", ":sbnext", or ":sbrewind".The
:stag/:stselect/:stjumpcommands also split windows and open a new buffer. Therefore, users expect them to be influenced by'switchbuf'as well, but they currently are not. When navigating tags,:set switchbuf=useopencan have great benefits: It avoids that multiple buffers with the same source file are opened; users will end up with the minimum amount of split windows, just one for each source file, and do not have to manually manage duplicate window splits. This deleted question on Stack Overflow asks for this explicitly. I want this, too, and think this is a change that most users would welcome, and would add more consistency to the Vim command set. Users that don't like this behavior probably don't have'switchbuf'configured, anyway.The implementation in
jumpto_tag()parallels the one inbuflist_getfile().getfile_result, already used later as a flag is now initialized at the beginning of the function, and used to actually skip thegetfile()call if a window reuse has happened.