-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
runtime(sml): fix number regex #18690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: tocariimaa <[email protected]>
Signed-off-by: tocariimaa <[email protected]>
|
IIRC Markus isn't really maintaining this file these days so he might be willing to hand over the reigns if you approach him about it. |
Fix the regex for reals too, I had forgot about it. Signed-off-by: tocariimaa <[email protected]>
|
FWIW, The additions for words look good. |
|
No it is part of the literal. The grammar uses the same production for the exponent as well.
|
|
Thanks. so, do you want to check with Markus if a maintainer change would make sense? |
I was planning on contacting him after this PR since I got more changes in the syntax file I want to make a PR of later |
|
When you're working on it @tocariimaa it might be helpful to keep in mind that it was, I seem to recall, a port of the OCaml syntax file and there's always been some lingering OCaml-isms. |
Yeah I also noticed that, I'll clean those later. |
|
okay thanks, then let me include it now |
closes: vim/vim#18690 vim/vim@d3bef6c Co-authored-by: tocariimaa <[email protected]>
…36513) closes: vim/vim#18690 vim/vim@d3bef6c Co-authored-by: tocariimaa <[email protected]>
Problem: the regex for number literals is wrong, first it uses
-for negative numbers instead of~; second, it allows0Xas the hexadecimal literal prefix (SML only supports using0x); and third, it doesn't recognize word literals (like0w1234or0wx2fe).Solution: correct the regex.