Refactor strings.c to remove calls to STRLEN() #18617
Open
+24
−25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some same refactoring of functions in strings.c to remove calls to
STRLEN().Specifically:
In
vim_strsave_shellescape()a small cosmetic change.In
string_count()move the call toSTRLEN()outside thewhileloop.In
copy_first_char_to_tv()change to return-1on failure or the length of resultingv_string. Changestring_filter_map()andstring_reduce()to use the return value ofcopy_first_char_to_tv().In
blob_from_string()refactor to remove call toSTRLEN().In
string_from_blob()callvim_strnsave()instead ofvim_strsave().In
vim_snprintf_safelen()callvim_vsnprintf_typval()directly instead ofvim_vsnprintf()which then callsvim_vsnprintf_typval().Cheers
John