runtime:compiler:feat: unify node-based makeprgs #18798
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,13 +1,23 @@ | ||
| " Vim compiler file | ||
| " Compiler: csslint for CSS | ||
| " Previous Maintainer: Daniel Moch <[email protected]> | ||
| " Last Change: 2016 May 21 | ||
| " 2024 Apr 03 by The Vim Project (removed :CompilerSet | ||
| " definition) | ||
| " 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
| endif | ||
| let current_compiler = "csslint" | ||
|
|
||
| " CompilerSet makeprg=csslint | ||
| " CompilerSet makeprg=npx\ csslint | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'csslint_makeprg', get(g:, 'csslint_makeprg', ''))) ? | ||
| \ get(b:, 'csslint_makeprg', get(g:, 'csslint_makeprg', '')) : | ||
|
Member
There was a problem hiding this comment. same here, let's not introduce another block of settings but stick to |
||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' csslint')) | ||
| \ .. ' --format=compact ' .. | ||
| \ get(b:, 'csslint_makeprg_params', get(g:, 'csslint_makeprg_params', '')), ' \|"') | ||
|
|
||
| CompilerSet errorformat=%-G,%-G%f:\ lint\ free!,%f:\ line\ %l\\,\ col\ %c\\,\ %trror\ -\ %m,%f:\ line\ %l\\,\ col\ %c\\,\ %tarning\ -\ %m,%f:\ line\ %l\\,\ col\ %c\\,\ %m | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,11 +2,19 @@ | |
| " Compiler: ESLint for JavaScript | ||
| " Maintainer: Romain Lafourcade <[email protected]> | ||
| " Last Change: 2024 Nov 30 | ||
| " 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
| endif | ||
| let current_compiler = "eslint" | ||
|
|
||
| " CompilerSet makeprg=eslint | ||
| " CompilerSet makeprg=npx\ eslint | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'eslint_makeprg', get(g:, 'eslint_makeprg', ''))) ? | ||
| \ get(b:, 'eslint_makeprg', get(g:, 'eslint_makeprg', '')) : | ||
|
|
||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' eslint')) | ||
| \ .. ' --format stylish ' .. | ||
| \ get(b:, 'eslint_makeprg_params', get(g:, 'eslint_makeprg_params', '')), ' \|"') | ||
| CompilerSet errorformat=%-P%f,\%\\s%#%l:%c\ %#\ %trror\ \ %m,\%\\s%#%l:%c\ %#\ %tarning\ \ %m,\%-Q,\%-G%.%#, | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| " Vim compiler file | ||
| " Compiler: Jest | ||
| " Maintainer: Doug Kearns <[email protected]> | ||
| " Last Change: 2024 Apr 03 | ||
| " Last Change: 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
|
|
@@ -13,7 +14,14 @@ set cpo&vim | |
|
|
||
| " CompilerSet makeprg=npx\ --no-install\ jest\ --no-colors | ||
|
|
||
| " CompilerSet makeprg=jest | ||
| " CompilerSet makeprg=npx\ jest | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'jest_makeprg', get(g:, 'jest_makeprg', ''))) ? | ||
| \ get(b:, 'jest_makeprg', get(g:, 'jest_makeprg', '')) : | ||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' jest')) | ||
| \ .. ' --no-colors ' .. | ||
| \ get(b:, 'jest_makeprg_params', get(g:, 'jest_makeprg_params', '')), ' \|"') | ||
| CompilerSet errorformat=%-A\ \ ●\ Console, | ||
| \%E\ \ ●\ %m, | ||
| \%Z\ %\\{4}%.%#Error:\ %f:\ %m\ (%l:%c):%\\=, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| " Vim compiler file | ||
| " Compiler: JSHint | ||
| " Maintainer: Doug Kearns <[email protected]> | ||
| " Last Change: 2024 Apr 03 | ||
| " Last Change: 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
|
|
@@ -13,9 +14,16 @@ set cpo&vim | |
|
|
||
| " CompilerSet makeprg=npx\ jshint\ --verbose | ||
|
|
||
| " CompilerSet makeprg=jshint | ||
| " CompilerSet makeprg=npx\ jshint | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'jshint_makeprg', get(g:, 'jshint_makeprg', ''))) ? | ||
| \ get(b:, 'jshint_makeprg', get(g:, 'jshint_makeprg', '')) : | ||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' jshint')) | ||
| \ .. ' --verbose ' .. | ||
| \ get(b:, 'jshint_makeprg_params', get(g:, 'jshint_makeprg_params', '')), ' \|"') | ||
| CompilerSet errorformat=%f:\ line\ %l\\,\ col\ %c\\,\ %m\ (%t%n), | ||
| \%-G%.%# | ||
|
|
||
| let &cpo = s:cpo_save | ||
| unlet s:cpo_save | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| " Vim compiler file | ||
| " Compiler: JSON Lint | ||
| " Maintainer: Doug Kearns <[email protected]> | ||
| " Last Change: 2024 Apr 03 | ||
| " Last Change: 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
|
|
@@ -13,9 +14,16 @@ set cpo&vim | |
|
|
||
| " CompilerSet makeprg=npx\ jsonlint\ --compact\ --quiet | ||
|
|
||
| " CompilerSet makeprg=jsonlint | ||
| " CompilerSet makeprg=npx\ jsonlint | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'jsonlint_makeprg', get(g:, 'jsonlint_makeprg', ''))) ? | ||
| \ get(b:, 'jsonlint_makeprg', get(g:, 'jsonlint_makeprg', '')) : | ||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' jsonlint')) | ||
| \ .. ' --compact --quiet ' .. | ||
| \ get(b:, 'jsonlint_makeprg_params', get(g:, 'jsonlint_makeprg_params', '')), ' \|"') | ||
| CompilerSet errorformat=%f:\ line\ %l\\,\ col\ %c\\,\ found:\ %m, | ||
| \%-G%.%# | ||
|
|
||
| let &cpo = s:cpo_save | ||
| unlet s:cpo_save | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,9 @@ | ||
| " Vim compiler file | ||
| " Compiler: Pylint for Python | ||
| " Previous Maintainer: Daniel Moch <[email protected]> | ||
| " Last Change: 2024 Nov 07 by The Vim Project (added params variable) | ||
| " 2024 Nov 19 by the Vim Project (properly escape makeprg setting) | ||
| " 2025 Nov 06 by the Vim Project (do not set buffer-local makeprg) | ||
|
|
||
| if exists("current_compiler") | finish | endif | ||
| let current_compiler = "pylint" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| " Vim compiler file | ||
| " Compiler: Sass | ||
| " Maintainer: Tim Pope <[email protected]> | ||
| " Last Change: 2016 Aug 29 | ||
| " 2024 Apr 03 by The Vim Project (removed :CompilerSet definition) | ||
| " 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
|
|
@@ -12,7 +13,14 @@ let current_compiler = "sass" | |
| let s:cpo_save = &cpo | ||
| set cpo-=C | ||
|
|
||
| " CompilerSet makeprg=sass | ||
| " CompilerSet makeprg=npx\ sass | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'sass_makeprg', get(g:, 'sass_makeprg', ''))) ? | ||
| \ get(b:, 'sass_makeprg', get(g:, 'sass_makeprg', '')) : | ||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' sass')) | ||
| \ .. ' ' .. | ||
| \ get(b:, 'sass_makeprg_params', get(g:, 'sass_makeprg_params', '')), ' \|"') | ||
|
|
||
| CompilerSet errorformat= | ||
| \%f:%l:%m\ (Sass::Syntax%trror), | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,12 +2,20 @@ | |
| " Compiler: Standard for JavaScript | ||
| " Maintainer: Romain Lafourcade <[email protected]> | ||
| " Last Change: 2020 August 20 | ||
| " 2024 Apr 03 by The Vim Project (removed :CompilerSet definition) | ||
| " 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
| endif | ||
| let current_compiler = "standard" | ||
|
|
||
| " CompilerSet makeprg=standard | ||
| " CompilerSet makeprg=npx\ standard | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'standard_makeprg', get(g:, 'standard_makeprg', ''))) ? | ||
| \ get(b:, 'standard_makeprg', get(g:, 'standard_makeprg', '')) : | ||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' standard')) | ||
| \ .. ' ' .. | ||
| \ get(b:, 'standard_makeprg_params', get(g:, 'standard_makeprg_params', '')), ' \|"') | ||
| CompilerSet errorformat=%f:%l:%c:\ %m,%-G%.%# | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| " Vim compiler file | ||
| " Compiler: Stylelint | ||
| " Maintainer: Doug Kearns <[email protected]> | ||
| " Last Change: 2024 Apr 03 | ||
| " 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
|
|
@@ -13,10 +14,17 @@ set cpo&vim | |
|
|
||
| " CompilerSet makeprg=npx\ stylelint\ --formatter\ compact | ||
|
|
||
| " CompilerSet makeprg=stylelint | ||
| " CompilerSet makeprg=npx\ stylelint | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'stylelint_makeprg', get(g:, 'stylelint_makeprg', ''))) ? | ||
| \ get(b:, 'stylelint_makeprg', get(g:, 'stylelint_makeprg', '')) : | ||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' stylelint')) | ||
| \ .. ' --formatter compact ' .. | ||
| \ get(b:, 'stylelint_makeprg_params', get(g:, 'stylelint_makeprg_params', '')), ' \|"') | ||
| CompilerSet errorformat=%f:\ line\ %l\\,\ col\ %c\\,\ %trror\ -\ %m, | ||
| \%f:\ line\ %l\\,\ col\ %c\\,\ %tarning\ -\ %m, | ||
| \%-G%.%# | ||
|
|
||
| let &cpo = s:cpo_save | ||
| unlet s:cpo_save | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| " Vim compiler file | ||
| " Compiler: TypeScript Runner | ||
| " Maintainer: Doug Kearns <[email protected]> | ||
| " Last Change: 2024 Apr 03 | ||
| " 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
|
|
@@ -11,9 +12,14 @@ let current_compiler = "node" | |
| let s:cpo_save = &cpo | ||
| set cpo&vim | ||
|
|
||
| " CompilerSet makeprg=ts-node | ||
| " CompilerSet makeprg=npx\ ts-node | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'ts_node_makeprg', get(g:, 'ts_node_makeprg', ''))) ? | ||
| \ get(b:, 'ts_node_makeprg', get(g:, 'ts_node_makeprg', '')) : | ||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' ts-node')) | ||
| \ .. ' ' .. | ||
| \ get(b:, 'ts_node_makeprg_params', get(g:, 'ts_node_makeprg_params', '')), ' \|"') | ||
| CompilerSet errorformat=%f\ %#(%l\\,%c):\ %trror\ TS%n:\ %m, | ||
| \%E%f:%l, | ||
| \%+Z%\\w%\\+Error:\ %.%#, | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,9 @@ | ||
| " Vim compiler file | ||
| " Compiler: TypeScript Compiler | ||
| " Maintainer: Doug Kearns <[email protected]> | ||
| " Last Change: 2024 Apr 03 | ||
| " 2025 Mar 11 by The Vim Project (add comment for Dispatch, add tsc_makeprg variable) | ||
| " 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
|
|
@@ -14,7 +15,13 @@ set cpo&vim | |
|
|
||
| " CompilerSet makeprg=tsc | ||
| " CompilerSet makeprg=npx\ tsc | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'tsc_makeprg', get(g:, 'tsc_makeprg', ''))) ? | ||
| \ get(b:, 'tsc_makeprg', get(g:, 'tsc_makeprg', '')) : | ||
| \ get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' tsc') | ||
| \ .. ' ' .. | ||
| \ get(b:, 'tsc_makeprg_params', get(g:, 'tsc_makeprg_params', '')), ' \|"') | ||
|
|
||
| CompilerSet errorformat=%f\ %#(%l\\,%c):\ %trror\ TS%n:\ %m, | ||
| \%trror\ TS%n:\ %m, | ||
| \%-G%.%# | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,8 @@ | ||
| " Vim compiler file | ||
| " Compiler: TypeDoc | ||
| " Maintainer: Doug Kearns <[email protected]> | ||
| " Last Change: 2024 Apr 03 | ||
| " 2025 Nov 22 by The Vim Project (default to npx) | ||
|
|
||
| if exists("current_compiler") | ||
| finish | ||
|
|
@@ -13,7 +14,14 @@ set cpo&vim | |
|
|
||
| " CompilerSet makeprg=npx\ typedoc | ||
|
|
||
| " CompilerSet makeprg=typedoc | ||
| " CompilerSet makeprg=npx\ typedoc | ||
| exe 'CompilerSet makeprg=' .. escape( | ||
| \ (!empty(get(b:, 'typedoc_makeprg', get(g:, 'typedoc_makeprg', ''))) ? | ||
| \ get(b:, 'typedoc_makeprg', get(g:, 'typedoc_makeprg', '')) : | ||
| \ (get(b:, 'javascript_node_makeprg', get(g:, 'javascript_node_makeprg', 'npx')) .. ' typedoc')) | ||
| \ .. ' ' .. | ||
| \ get(b:, 'typedoc_makeprg_params', get(g:, 'typedoc_makeprg_params', '')), ' \|"') | ||
| CompilerSet errorformat=%EError:\ %f(%l), | ||
| \%WWarning:\ %f(%l), | ||
| \%+IDocumentation\ generated\ at\ %f, | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Biome is quite new, let's rather keep it simple and jut use the
javascript_node_makeprginstead and get rid of the wholebiome_makeprgoption instead. This simplifies this whole thing here.