fix(quickfix): restore correct window when closing quickfix #18961
+40
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8e40940 to
422ba59
Compare
h-east
reviewed
Dec 18, 2025
yegappan
reviewed
Dec 18, 2025
yegappan
reviewed
Dec 18, 2025
422ba59 to
b0e8b61
Compare
zeertzjq
reviewed
Dec 19, 2025
b0e8b61 to
aa281b1
Compare
zeertzjq
reviewed
Dec 19, 2025
Problem: After `botright copen` and close this quikfix window, cursor ends up in the wrong window. The problem is fr_child always points to the first (leftmost for FR_ROW, topmost for FR_COL) child frame. When do :vsplit, the new window is created on the left, and frame_insert() updates the parent's fr_child to point to this new left window. Solution: Same as help windows - snapshot before open, restore when close.
aa281b1 to
3a65c4a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
After
botright copenand close this quikfix window, cursor ends up in the wrong window. The problem is fr_child always points to the first (leftmost for FR_ROW, topmost for FR_COL) child frame. When do :vsplit, the new window is created on the left, and frame_insert() updates the parent's fr_child to point to this new left window.Solution:
Same as help windows - snapshot before open, restore when close.